Allow disabling automatic terminal title#2832
Open
savchenko wants to merge 2 commits intogitui-org:masterfrom
Open
Allow disabling automatic terminal title#2832savchenko wants to merge 2 commits intogitui-org:masterfrom
savchenko wants to merge 2 commits intogitui-org:masterfrom
Conversation
Add `--no-terminal-title/-n` flags to disable automatic terminal title setup which was introduced in 3ede6b5 Close gitui-org#2831
Add information about gitui-org#2832
Author
|
@extrawurst , any chance this can be added to v0.28.1 ? |
Collaborator
|
Not against it but no priority. First I want the marked ones reviewed and merged. Feel free to leave reviews please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--no-terminal-title/-nflags to disable automatic terminal title setup which was introduced in 3ede6b5This Pull Request fixes/closes #2831.
It changes the following:
start_terminal()now acceptsno_terminal_titleI followed the checklist:
make checkwithout errors