fix(delete): Check if remote exists before deleting it#83
Open
dermojo wants to merge 1 commit intogittower:mainfrom
Open
fix(delete): Check if remote exists before deleting it#83dermojo wants to merge 1 commit intogittower:mainfrom
dermojo wants to merge 1 commit intogittower:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make git flow <type> delete --remote resilient when the remote branch no longer exists (e.g., deleted via web UI), treating that case as non-fatal and resolving #82.
Changes:
- Adds a pre-check before attempting remote branch deletion in the delete command.
- Updates the delete command test to expect success when the remote branch is missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/delete.go | Skips remote deletion attempt based on a remote-branch existence check. |
| test/cmd/delete_test.go | Updates test expectations to treat deleting a non-existent remote branch as success. |
When deleting a remote branch, check whether if exists first. Trying to delete a branch that doesn't exist anymore isn't a failure. Resolves gittower#82
dermojo
force-pushed
the
bugfix/82-delete-remote
branch
from
895549f to
2318250
Compare
Author
|
Is there anything left to do for me in this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a remote branch, check whether if exists first. Trying to delete a branch that doesn't exist anymore isn't a failure.
The implemented fix is a simple check before trying to delete the remote branch.
Resolves #82