Add refresh and quick add commands with menu integration#1
Add refresh and quick add commands with menu integration#1devTarik wants to merge 1 commit intogittower:mainfrom
Conversation
|
@andrei-git-tower please do a PR review |
|
Is this brand new project already stalled ? |
Hi, it looks like this brand new project already stalled |
|
Hey @emmanuelprecieuxargent and @devTarik Apologize for the late reply here, most of our focus was on the main repo. We'll look at this PR and review it in the upcoming week. Thank you! |
There was a problem hiding this comment.
This file looks like a working/process document from your development workflow, it doesn't need to be included in the PR.
| await updateContextVariables(); | ||
| treeDataProvider.refresh(); | ||
| } catch (error) { | ||
| // Silently fail if there's an error |
There was a problem hiding this comment.
Since this is a user-initiated action, it'd be good to surface any errors rather than silently swallowing them. The existing pattern in the extension is vscode.window.showErrorMessage(...), something like vscode.window.showErrorMessage(Failed to refresh: ${error}) would keep it consistent.
|
|
||
| await updateContextVariables(); | ||
| } catch (error) { | ||
| // Silently fail if there's an error |
There was a problem hiding this comment.
Same as above, we should surface any errors to the user.
| // Register refresh command early so header button works immediately | ||
| const refreshCommand = vscode.commands.registerCommand('git-flow-next.refresh', async () => { | ||
| try { | ||
| console.log('git-flow-next.refresh invoked'); |
There was a problem hiding this comment.
The debug log should be removed before merging
| } | ||
| }); | ||
| context.subscriptions.push(refreshCommand); | ||
| console.log('git-flow-next.refresh registered'); |
There was a problem hiding this comment.
The debug log should be removed before merging
| "typescript": "^4.9.4" | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
minor thing here to fix: newline missing
4 participants
Description
Added two new commands to improve UX when working with git-flow branches:
New Features:
Refresh Overview
Add Branch
Context Menu (right-click) on branches
Details: