Skip to content

[docs] Fix table scaling for languages and frameworks #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JesterOrNot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[docs] Fix table scaling for languages and frameworks #637

JesterOrNot wants to merge 1 commit into from

Conversation

@JesterOrNot
Copy link
Contributor

@JesterOrNot JesterOrNot commented May 16, 2020 •
edited
Loading

Fixes #495

Please excuse my poor CSS skills 😅.

Old button sizes

image

New button sizes

image

This makes the images seem more clear

nisarhassan12
nisarhassan12 suggested changes May 17, 2020
View reviewed changes
Copy link
Contributor

@nisarhassan12 nisarhassan12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many Thanks! 🙂 for the Pr.

With your change, the overall font size for the table is a bit smaller.

Before:

image

Now:

image

I personally prefer the larger font-size on large devices. Currently, I don't know of a solution via which we can align the tables so that users don't have to use the scrollbars to view the offscreen contents of the table.

nisarhassan12
nisarhassan12 reviewed May 17, 2020
View reviewed changes
nisarhassan12
nisarhassan12 reviewed May 17, 2020
View reviewed changes
@nisarhassan12
Copy link
Contributor

nisarhassan12 commented May 18, 2020

Currently, I don't know of a solution via which we can align the tables so that users don't have to use the scrollbars to view the offscreen contents of the table.

@ChristinFrohne Do you have any ideas on How way may achieve this? sites usually use horizontal scroll for tables when the device width is small.

@chrifro
Copy link
Contributor

chrifro commented May 18, 2020

Currently, I don't know of a solution via which we can align the tables so that users don't have to use the scrollbars to view the offscreen contents of the table.
@ChristinFrohne Do you have any ideas on How way may achieve this? sites usually use horizontal scroll for tables when the device width is small.

What about having only two cells on mobile and just adding the open in Gitpodbutton underneath each description?

@JesterOrNot JesterOrNot force-pushed the sh/scale-example-tables branch from 2eb80d0 to 33a66f9 Compare May 20, 2020 01:19
@nisarhassan12
[docs] Fix table scaling for languages and frameworks
8ff6afb 
Fixes #495

Update src/docs/languages/bash.md

Co-authored-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>

Update src/styles/normalize.ts

Co-authored-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>

Update src/docs/languages/cpp.md

Co-authored-by: Nisar Hassan Naqvi <syednisarhassan12@gmail.com>
@JesterOrNot JesterOrNot force-pushed the sh/scale-example-tables branch from 33a66f9 to 8ff6afb Compare May 20, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jankeromnes jankeromnes Awaiting requested review from jankeromnes

1 more reviewer

@nisarhassan12 nisarhassan12 nisarhassan12 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Languages and Frameworks Scaling on Mobile

4 participants

@JesterOrNot @nisarhassan12 @chrifro