update ethereum.org comment for 2025#46
Merged
colfax23 merged 2 commits intogitpoap:mainfrom Feb 5, 2025
Merged
Conversation
|
@corwintines is attempting to deploy a commit to the GitPOAP Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
colfax23
requested changes
Jan 26, 2025
Contributor
colfax23
left a comment
colfax23
left a comment
There was a problem hiding this comment.
Looks great overall, just one comment on the copy. Let me know what you think. Excited to get this out!
src/utils.ts
Outdated
Contributor
There was a problem hiding this comment.
I'd rather not advertise other badge platforms through the GitPOAP bot - do you mind changing it just to "you may also unlock additional badges" or " ... additional rewards"?
Contributor
Author
There was a problem hiding this comment.
Can change this for sure!
Contributor
Author
There was a problem hiding this comment.
Took this out now, let me know if theres anything else needed :)
corwintines
commented
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the comment for ethereum.org gitpoap for 2025