fix(mft): restore OFFLINE path sorting (5/6 SORTED MATCH)#5
Merged
githubrobbi merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
… pass) Commit 90ee522 removed all sort_directory_children() calls to match C++ LIVE behavior, but this broke OFFLINE mode (0/6 drives passing). OFFLINE paths need sorting for deterministic output since MFT dump parsing order differs from live IOCP traversal. Changes: - Restore sort_directory_children() before compute_tree_metrics() in all 3 OFFLINE code paths: builder.rs, persistence.rs, merge.rs - Add --format custom to verify_parity.rs to match C++ baseline footer Verified: D, E, G, M, S all SORTED MATCH. F is known deferred (Bug 3). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores OFFLINE MFT processing to 5/6 SORTED MATCH state after regression from commit 90ee522.
What was broken
Fix
Re-added sort_directory_children() to OFFLINE paths:
Fixed verify_parity.rs to use --format custom for C++ footer parity
Result
5/6 SORTED MATCH restored ✅
🤖 Generated with Claude Code