Fix Drive D/S parity: remove premature metrics + child sorting#4
Merged
githubrobbi merged 1 commit intomainfrom Mar 16, 2026
Merged
Fix Drive D/S parity: remove premature metrics + child sorting#4githubrobbi merged 1 commit intomainfrom
githubrobbi merged 1 commit intomainfrom
Conversation
…+ parity Drive D root cause: to_index.rs called compute_tree_metrics() before returning to index_read.rs, which sorted and recomputed. The premature call on unsorted children produced wrong directory sizes. Drive S root cause: C++ outputs children in reverse MFT parse order (no sorting). Rust sorted alphabetically, causing 99.96% diff rate. Files were identical — only ordering differed. Fix: Remove all sort_directory_children() calls (C++ doesn't sort) and remove premature compute_tree_metrics() from inline IOCP readers. Tree metrics are now computed exactly once per read path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_tree_metrics()from IOCP inline readers (to_index.rs,to_index_parallel.rs). These called metrics before sort, producing wrong directory sizes. Now metrics are computed exactly once in the caller.sort_directory_children()calls. C++ outputs children in reverse MFT parse order (no sorting). Rust was sorting alphabetically, causing 99.96% diff rate on Drive S.Expected Impact
Test plan
just checkpasses🤖 Generated with Claude Code