Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 24, 2025

The safe-outputs MCP server entry point is now deployed as a static file through the setup-safe-outputs action instead of being generated inline in each workflow.

Changes

1. Created Static Entry Point File

  • Added pkg/workflow/js/safe_outputs_mcp_server_entry_point.cjs as a source file
  • Registered it in pkg/workflow/js.go with //go:embed directive
  • Added to GetJavaScriptSources() map for build system access

2. Updated Action Build Configuration

  • Modified pkg/cli/actions_build_command.go to include entry point in setup-safe-outputs dependencies
  • Updated actions/setup-safe-outputs/copy-files.sh to rename safe_outputs_mcp_server_entry_point.cjs to mcp-server.cjs during copy

3. Removed Inline Generation

  • Removed "Write Safe Outputs MCP Server Entry Point" step from pkg/workflow/mcp_servers.go
  • Entry point is now consistently deployed by the action across all workflows

Impact

  • All 123 compiled workflows updated
  • Total workflow size reduced from 29.0 MB to 28.9 MB
  • 119 workflow steps removed (one per workflow using safe-outputs)
  • Entry point now managed as a source file instead of generated inline

Testing

  • ✅ All workflows compile successfully
  • ✅ Verified copy-files.sh correctly renames entry point to mcp-server.cjs
  • ✅ Confirmed entry point file structure matches original generated version
Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20485738054/job/58867742522#step:46:1

Investigate why safeoutputs fails to launch


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Investigate why safeoutputs fails to launch Fix incorrect indentation in safe-outputs MCP server entry point script Dec 24, 2025
Copilot AI requested a review from pelikhan December 24, 2025 12:32
uses: ./actions/setup-safe-outputs
with:
destination: /tmp/gh-aw/safeoutputs
- name: Write Safe Outputs MCP Server Entry Point
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove this step, the files are installed by the action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The "Write Safe Outputs MCP Server Entry Point" step has been removed from all workflows in commit 15e4720.

The entry point mcp-server.cjs is now:

  1. Created as a source file (safe_outputs_mcp_server_entry_point.cjs)
  2. Included in the action's dependencies and built into actions/setup-safe-outputs/js/
  3. Automatically copied and renamed to mcp-server.cjs by the action's copy-files.sh script

Verified: Compiled all 123 workflows successfully. The entry point step is no longer generated.

… installed by the action

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Fix incorrect indentation in safe-outputs MCP server entry point script Remove inline safe-outputs MCP server entry point generation - files now installed by action Dec 24, 2025
Copilot AI requested a review from pelikhan December 24, 2025 12:48
@pelikhan pelikhan marked this pull request as ready for review December 24, 2025 12:49
@pelikhan pelikhan merged commit 267ccb9 into copilot/copy-js-files-to-safeoutputs Dec 24, 2025
@pelikhan pelikhan deleted the copilot/investigate-safeoutputs-launch-issue branch December 24, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants