feat: add support for campaign objectives and kpis #7237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mnkiefer
commented
Dec 22, 2025
mnkiefer
commented
- Enhanced CampaignSpec to include Objective and KPIs fields.
- Updated BuildOrchestrator to render Objective and KPIs in markdown.
- Added validation rules to ensure consistency between Objective and KPIs.
- Introduced new tests to validate the behavior of Objective and KPIs.
- Updated orchestrator instructions to include guidance on Objective and KPIs.
- Modified JSON schema to reflect new fields for campaign specifications.
- Improved error handling in push_repo_memory.js for campaign mode.
- Enhanced CampaignSpec to include Objective and KPIs fields. - Updated BuildOrchestrator to render Objective and KPIs in markdown. - Added validation rules to ensure consistency between Objective and KPIs. - Introduced new tests to validate the behavior of Objective and KPIs. - Updated orchestrator instructions to include guidance on Objective and KPIs. - Modified JSON schema to reflect new fields for campaign specifications. - Improved error handling in push_repo_memory.js for campaign mode.
Contributor
Author
|
@copilot: make lint. |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the campaign system by adding first-class support for campaign objectives and KPIs (Key Performance Indicators). The changes enable campaigns to define success criteria with measurable KPIs, enforce validation rules to ensure consistency, and render this information in orchestrator instructions to guide AI agents toward measurable outcomes.
Key changes:
- Added
Objective(string) andKPIs(array) fields toCampaignSpecwith corresponding validation - Enhanced campaign orchestrator to render objectives and KPIs in markdown output and agent instructions
- Implemented campaign mode enforcement in repo-memory push operations with validation for cursor and metrics snapshots
- Updated documentation to explain the objective/KPI model and campaign patterns
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
pkg/campaign/spec.go |
Added Objective field and CampaignKPI struct with validation constraints |
pkg/campaign/validation.go |
Implemented validateObjectiveAndKPIs() with coupling rules and KPI field validation |
pkg/campaign/validation_test.go |
Added comprehensive test coverage for objective/KPI validation scenarios |
pkg/campaign/orchestrator.go |
Updated to render objective and KPIs in markdown and pass to template data |
pkg/campaign/orchestrator_test.go |
Added test verifying objective/KPI rendering in orchestrator output |
pkg/campaign/template.go |
Extended CampaignPromptData with Objective, KPIs, and MetricsGlob fields |
pkg/campaign/loader.go |
Updated skeleton creation to include default MemoryPaths and MetricsGlob |
pkg/campaign/schemas/campaign_spec_schema.json |
Added JSON schema definitions for objective and kpis fields |
pkg/campaign/prompts/orchestrator_instructions.md |
Enhanced instructions with objective/KPI guidance and metrics collection requirements |
pkg/workflow/js/push_repo_memory.cjs |
Added campaign mode detection, validation functions, and path traversal protection |
pkg/cli/compile_campaign_orchestrator_test.go |
Updated test data to use simplified memory path patterns |
docs/src/content/docs/guides/campaigns/specs.md |
Rewrote to explain campaign model with objectives, KPIs, and repo-memory patterns |
docs/src/content/docs/guides/campaigns/getting-started.md |
Simplified getting started guide with objective/KPI examples |
docs/src/content/docs/guides/campaigns.md |
Refactored to emphasize delegation model and measurable outcomes |
Multiple .lock.yml files |
Compiled workflow outputs reflecting the updated push_repo_memory.cjs script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot: Only keep affected files in this PR, restore the others to main version. |
Contributor
pelikhan
requested changes
Dec 22, 2025
| const fs = require("fs"); | ||
| const path = require("path"); | ||
| const { execSync } = require("child_process"); | ||
| const core = require("@actions/core"); |
Contributor
There was a problem hiding this comment.
@mnkiefer this package is not available locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.