test(bash-lint): cover 'Stage repo execution context' generator#1095
Draft
github-actions[bot] wants to merge 1 commit into
Draft
test(bash-lint): cover 'Stage repo execution context' generator#1095github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add execution-context.repo.enabled: true to execution-context-agent.md so the RepoContextContributor's bash step is exercised by the lint. Track 'Stage repo execution context (aw-context/repo/*)' in REQUIRED_STEP_DISPLAY_NAMES so any future regression is caught. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the lint found
Proactive coverage audit found that
RepoContextContributor::prepare_step_typed()insrc/compile/extensions/exec_context/repo.rsemits a bash step with display nameStage repo execution context (aw-context/repo/*), but no fixture in the lint harness activated this contributor. The step was therefore never passed through shellcheck.Three other opt-in exec-context contributors (
ci-push,schedule,pr-checks) are similarly unreached and will be addressed in subsequent runs.How it was fixed
tests/fixtures/execution-context-agent.md— addedexecution-context: { repo: { enabled: true } }to the front matter. TheRepoContextContributoris purely config-driven (no trigger requirement, default OFF), so this single flag is sufficient to activate it. Updated the fixture description and body to document the third contributor.tests/bash_lint_tests.rs— added"Stage repo execution context (aw-context/repo/*)"toREQUIRED_STEP_DISPLAY_NAMESwith a source comment pointing atrepo.rs. Future regressions (e.g. a display-name rename or the contributor being gated out) will now surface as a test failure rather than silent uncoverage.The repo contributor's bash body is:
shellcheck passes cleanly —
set -euo pipefailis the correct idiomatic header and there are no variable-quoting or silent-failure issues.Verification
Warning
Firewall blocked 3 domains
The following domains were blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comspsprodeus21.vssps.visualstudio.comspsprodweu4.vssps.visualstudio.comSee Network Configuration for more information.