Conversation
…ro wavefront files. So far it's working (win qt6 only).
edit the other 2 project files do more testing in response to upcoming changes to wavefrontpro by jaco
for the Dale project file and the non-windows use of the project file and the QT5 build project file.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Only 7 out of 9 clang-tidy concerns fit within this pull request's diff.
Have any feedback or feature suggestions? Share it here.
|
🚀 New build available for commit |
|
This isn't quite ready to review. |
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Only 7 out of 9 clang-tidy concerns fit within this pull request's diff.
Have any feedback or feature suggestions? Share it here.
|
🚀 New build available for commit |
…or messages if npz file can't be read.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Only 6 out of 8 clang-tidy concerns fit within this pull request's diff.
Have any feedback or feature suggestions? Share it here.
|
🚀 New build available for commit |
|
@atsju, I fixed the memory leaks and I added the following change to build-linux-clazy.yml (screenshot below) but it is still giving me clang errors. I added this exclusion because cnpy is a library I downloaded and it's not my code. Does build-linux-clazy have to be merged with master before it is used by git? or am I doing something else wrong? 
|
…to go away the first time. Hopefully this is the right spot.
|
🚀 New build available for commit |
|
@atsju - nevermind. I figured it out. |
|
Ok, dale. This is ready for you to review. |
|
Hi, May I ask for a very small addition so that cnpy copyright gets distributed ? Add a copyright line to this file : https://github.com/githubdoe/DFTFringe/blob/wfpro/LICENSES/MIT.txt For homogeneity reasons you can also copy the original MIT licence from cnpy into the new cnpy folder. I wish you an excellent weekend ! |
3 participants
The DFTF user interface barely changes. I just added .npz to .wft as types of files to open and the code I added is called from all the places wavefront files are opened so I didn't have to change existing DFTF code much at all. Mostly I just added the code that reads this new format.
This change required adding to files in the .cnpy subfoder - this is the cnpy library (just 2 files) that can read npz "number python zipped) formatted files.
Also cnpy uses the zip library that zips and unzips files so I had to add "-lz" in project files to link to zlib library which comes standard with mingw. At the moment I only tested with QT5 and QT6. Creating this PR will let me know if this all works for the github automated builds as well.