This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with lambdas without parameters by making the capture of @params optional, ensuring that call edges are only emitted if parameters are present.
- Added a test case for lambdas without parameters.
- Verified lambdas with parameters continue to work as expected.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-python/src/stack-graphs.tsg: Language not supported
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lambda without parameters does not have a syntax for the parameters, unlike a function without parameters (which does, containing just the
(and)characters). The stanza for callables did not optionally match@params, causing it to miss lambdas without parameters entirely, which would then cause an error in a later stanza:The fragments of the parsed Tree-sitter tree for such lambda without and with parameters is:
As of v0.23.5 of the Python grammar,
lambdaindeed declares an optionalparametersfield.Making the
@paramscapture optional and only emitting the edges if it’s there fixes the issue.