This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Fix not defaulting to Builder::file for FILE_PATH.#466
Closed
bm-w wants to merge 1 commit intogithub:upgrade-tree-sitterfrom
Closed
Fix not defaulting to Builder::file for FILE_PATH.#466bm-w wants to merge 1 commit intogithub:upgrade-tree-sitterfrom
Builder::file for FILE_PATH.#466bm-w wants to merge 1 commit intogithub:upgrade-tree-sitterfrom
Conversation
Merged
hendrikvanantwerpen
changed the base branch from
main
to
upgrade-tree-sitter
Contributor
|
@bm-w I had some problems with CI that I tried to fix by changing the base branch. But when that got merged, it didn't update the base to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also this comment on #438.
The user is already passing
fileto create theBuilder; requiring that they additionally setFILE_PATHinglobalsis redundant and non-obvious.