Skip to content

fix(templates): add missing Assumptions section to spec template#1939

Merged
mnriem merged 1 commit intogithub:mainfrom
ismaelJimenez:fix/add-assumptions-section-to-spec-template
Mar 23, 2026
Merged

fix(templates): add missing Assumptions section to spec template#1939
mnriem merged 1 commit intogithub:mainfrom
ismaelJimenez:fix/add-assumptions-section-to-spec-template

Conversation

@ismaelJimenez
Copy link
Contributor

Description

The specify command references an "Assumptions section" in the spec template and instructs the agent to "document assumptions in Assumptions section" and "Record reasonable defaults in the Assumptions section." The quality checklist also validates "Dependencies and assumptions identified." However, the actual spec-template.md did not contain an Assumptions section. This caused a mismatch: the agent would try to populate a section that didn't exist in the template.

This PR adds the missing ## Assumptions section to spec-template.md with placeholder bullets covering:

  • Target users/environment assumptions
  • Scope boundary assumptions
  • Data/infrastructure assumptions
  • Dependencies on existing systems/services

Testing

  • Ran existing tests with uv sync && uv run pytest
  • Tested with a sample project

AI Disclosure

  • I did use AI assistance (describe below)

The Assumptions section layout and placeholder bullets were drafted with the help of AI (GitHub Copilot).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing Assumptions section to the feature spec template so it aligns with the specify command guidance and the spec quality checklist (which already reference documenting assumptions).

Changes:

  • Add a new ## Assumptions section to templates/spec-template.md with placeholder guidance and example bullets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mnriem mnriem merged commit dc7f09a into github:main Mar 23, 2026
12 checks passed
jonasbokim added a commit to Jonas-Construction-Software/jonas-spec-kit-dev that referenced this pull request Mar 26, 2026
…nc-main-2026-03-25

* upstream/main: (90 commits)
  fix(ps1): replace null-conditional operator for PowerShell 5.1 compatibility (github#1975)
  chore: bump version to 0.4.2 (github#1973)
  feat: Auto-register ai-skills for extensions whenever applicable (github#1840)
  docs: add manual testing guide for slash command validation (github#1955)
  Add AIDE, Extensify, and Presetify to community extensions (github#1961)
  docs: add community presets section to main README (github#1960)
  docs: move community extensions table to main README for discoverability (github#1959)
  docs(readme): consolidate Community Friends sections and fix ToC anchors (github#1958)
  fix(commands): rename NFR references to success criteria in analyze and clarify (github#1935)
  Add Community Friends section to README (github#1956)
  docs: add Community Friends section with Spec Kit Assistant VS Code extension (github#1944)
  chore: bump version to 0.4.1 (github#1953)
  Add checkpoint extension (github#1947)
  fix(scripts): prioritize .specify over git for repo root detection (github#1933)
  docs: add AIDE extension demo to community projects (github#1943)
  fix(templates): add missing Assumptions section to spec template (github#1939)
  chore: bump version to 0.4.0 (github#1937)
  fix(cli): add allow_unicode=True and encoding="utf-8" to YAML I/O (github#1936)
  fix(codex): native skills fallback refresh + legacy prompt suppression (github#1930)
  feat(cli): embed core pack in wheel for offline/air-gapped deployment (github#1803)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants