Bump to Node LTS

.devcontainer/Dockerfile

@@ -1,5 +1,5 @@
 # [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
-ARG VARIANT=16-bullseye
+ARG VARIANT=18-bullseye
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 # [Optional] Uncomment this section to install additional OS packages.
@@ -14,6 +14,11 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
 # ARG EXTRA_NODE_VERSION=10
 # RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
 
+# Install nvm
+ENV NVM_DIR /usr/local/nvm
+RUN curl https://raw.githubusercontent.com/creationix/nvm/v0.20.0/install.sh | bash \
+    && . $NVM_DIR/nvm.sh
+
 # [Optional] Uncomment if you want to install more global node modules
 # RUN su node -c "npm install -g <your-package-list-here>"
 RUN su node -c "npm install -g sfdx-cli"

.devcontainer/devcontainer.json

@@ -1,36 +1,36 @@
 // For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
 // https://github.com/microsoft/vscode-dev-containers/tree/v0.162.0/containers/javascript-node
 {
-    "name": "Node.js",
-    "build": {
-      "dockerfile": "Dockerfile",
-      // Update 'VARIANT' to pick a Node version: 10, 12, 14
-      "args": { "VARIANT": "14" }
-    },
-  
-    // Set *default* container specific settings.json values on container create.
-    // "settings": {},
-  
-    // Add the IDs of extensions you want installed when the container is created.
-    "extensions": [
-      "dbaeumer.vscode-eslint",
-      "esbenp.prettier-vscode",
-      "salesforce.salesforcedx-vscode-expanded"
-    ],
-  
-    // Use 'forwardPorts' to make a list of ports inside the container available locally.
-    // "forwardPorts": [],
-  
-    // Use 'postCreateCommand' to run commands after the container is created.
-    // "postCreateCommand": "yarn install",
-    "postCreateCommand": "bash scripts/codespaces/setup",
-  
-    // Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
-    "remoteUser": "node",
-    "features": {
-      "ghcr.io/devcontainers/features/git:1": {},
-      "ghcr.io/devcontainers/features/github-cli:1": {},
-      "ghcr.io/devcontainers/features/java:1": {},
-      "ghcr.io/devcontainers/features/common-utils:1": {}
-    }
-  }
+  "name": "Node.js",
+  "build": {
+    "dockerfile": "Dockerfile",
+    // Update 'VARIANT' to pick a Node version: 10, 12, 14
+    "args": { "VARIANT": "18" }
+  },
+
+  // Set *default* container specific settings.json values on container create.
+  // "settings": {},
+
+  // Add the IDs of extensions you want installed when the container is created.
+  "extensions": [
+    "dbaeumer.vscode-eslint",
+    "esbenp.prettier-vscode",
+    "salesforce.salesforcedx-vscode-expanded"
+  ],
+
+  // Use 'forwardPorts' to make a list of ports inside the container available locally.
+  // "forwardPorts": [],
+
+  // Use 'postCreateCommand' to run commands after the container is created.
+  // "postCreateCommand": "yarn install",
+  "postCreateCommand": "bash scripts/codespaces/setup",
+
+  // Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
+  "remoteUser": "node",
+  "features": {
+    "ghcr.io/devcontainers/features/git:1": {},
+    "ghcr.io/devcontainers/features/github-cli:1": {},
+    "ghcr.io/devcontainers/features/java:1": {},
+    "ghcr.io/devcontainers/features/common-utils:1": {}
+  }
+}

.github/workflows/issue-branch-creation-handler.yml

@@ -12,7 +12,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: "14"
+          node-version-file: ".nvmrc"
       - name: Cache node modules
         uses: actions/cache@v3.0.11
         id: npm_cache_id

.github/workflows/release-branch-merge-handler.yml

@@ -32,26 +32,23 @@ jobs:
       - name: Compile Release Notes
         if: steps.check_merge.outputs.IS_MERGE == 'true' && vars.GENERATE_RELEASE == 'true'
         run: |
-          if [ls release-notes/${{ vars.ISSUE_BRANCH_PREFIX }}*.md 1> /dev/null 2>&1]
+          if ls release-notes/${{ vars.ISSUE_BRANCH_PREFIX }}*.md 1> /dev/null 2>&1
           then
-              if [ ! -f $1 ]
-              then
-                  echo "### Includes the following items" > $1
-                  echo >> $1
-              fi
+              echo "### Includes the following items" > 'release-notes/release.md'
+              echo >> 'release-notes/release.md'
               for ISSUE_NOTES in `ls release-notes/${{ vars.ISSUE_BRANCH_PREFIX }}*.md`
               do
                   NOTES=`cat ${ISSUE_NOTES}`
-                  if ! grep -q "${NOTES}" $1
+                  if ! grep -q "${NOTES}" 'release-notes/release.md'
                   then
-                      echo "${NOTES}" >> $1
+                      echo "${NOTES}" >> 'release-notes/release.md'
                   fi
               done
           fi
       - name: Delete Artifacts
         if: steps.check_merge.outputs.IS_MERGE == 'true'
         run: |
-          if [${{ vars.GENERATE_RELEASE }} == 'true']; then rm release-notes/${{ vars.ISSUE_BRANCH_PREFIX }}*.md || true
+          if ${{ vars.GENERATE_RELEASE }} == 'true'; then rm release-notes/${{ vars.ISSUE_BRANCH_PREFIX }}*.md || true; fi
           rm auth/sandbox-login-url-issue-* || true
       - uses: stefanzweifel/git-auto-commit-action@v4.15.4
         if: steps.check_merge.outputs.IS_MERGE == 'true'

.github/workflows/release-branch-pull-request-handler.yml

@@ -14,7 +14,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v3.5.1
         with:
-          node-version: "14"
+          node-version-file: ".nvmrc"
       - name: Cache Node Modules
         uses: actions/cache@v3.0.11
         id: npm_cache_id

.nvmrc

@@ -0,0 +1 @@
+v18.12.1