Fix MCP prompt role to 'assistant' per spec#916
Closed
genius-0963 wants to merge 1 commit intogithub:mainfrom
Closed
Fix MCP prompt role to 'assistant' per spec#916genius-0963 wants to merge 1 commit intogithub:mainfrom
genius-0963 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
Collaborator
|
Thank you for your contribution, closing as it was previously addressed as per @LuluBeatson 's comment. |
Author
|
Happy new year
…On Thu, 1 Jan, 2026, 3:40 am Sam Morrow, ***@***.***> wrote:
*SamMorrowDrums* left a comment (github/github-mcp-server#916)
<#916 (comment)>
Thank you for your contribution, closing as it was previously addressed as
per @LuluBeatson <https://github.com/LuluBeatson> 's comment.
—
Reply to this email directly, view it on GitHub
<#916 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS4SHMOYFYWWSWWEFTS7PR34ERCUTAVCNFSM6AAAAACEGZ6SL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBSHE3DENZQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the MCP server to use role: "assistant" instead of role: "system" in prompt messages, in compliance with the MCP specification:
https://modelcontextprotocol.io/specification/2025-06-18/server/prompts#promptmessage
Reason:
Prevents errors in MCP Inspector and other tools expecting only user or assistant roles.
Resolves:
Files changed:
workflow_prompts.go
issues.go
Testing:
No errors found in the updated files.
MCP Inspector and other tools should now work as expected.