Add support for rulesets and custom properties.#821
Open
patrick-knight wants to merge 9 commits intogithub:mainfrom
Open
Add support for rulesets and custom properties.#821patrick-knight wants to merge 9 commits intogithub:mainfrom
patrick-knight wants to merge 9 commits intogithub:mainfrom
Conversation
Add comprehensive tests for GitHub repository ruleset functionalities - Implement tests for GetRepositoryRuleset, ListRepositoryRulesets, GetRepositoryRulesForBranch, GetOrganizationRepositoryRuleset, ListOrganizationRepositoryRulesets, ListRepositoryRuleSuites, and GetRepositoryRuleSuite functions. - Validate tool definitions, input schemas, and required parameters. - Mock GitHub API responses for various scenarios including successful fetches and error cases. - Ensure proper error handling and assertions for expected outcomes in tests.
Delete pkg/github/discussions_test.go
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive support for GitHub repository rules, rulesets, and rule suites across repository, organization, and enterprise levels. Additionally, it introduces custom properties functionality for repositories, organizations, and enterprises.
- Implements 15 new API tools covering rulesets, rule suites, and custom properties
- Adds extensive test coverage for all new ruleset and rule suite operations
- Creates a new enterprise toolset for enterprise-level operations
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Adds new tool registrations for rulesets, rule suites, and custom properties across repository, organization, and enterprise scopes |
| pkg/github/rules.go | Implements complete ruleset and rule suite functionality with both read and write operations |
| pkg/github/rules_test.go | Comprehensive test suite validating tool definitions, parameter validation, and API interactions |
| pkg/github/custom_properties.go | Implements custom properties management for repositories, organizations, and enterprises |
| pkg/github/toolsnaps/*.snap | Tool definition snapshots for automated validation |
| docs/remote-server.md | Documents new enterprise toolset availability |
| README.md | Updates documentation with all new tools and their parameters |
| pkg/github/discussions_test.go | File deletion (moved/consolidated elsewhere) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for GitHub repository rules, rulesets, and rule suites
Closes: #820