feat: add reviewers parameter to create_pull_request#814
Open
yukukotani wants to merge 3 commits intogithub:mainfrom
Open
feat: add reviewers parameter to create_pull_request#814yukukotani wants to merge 3 commits intogithub:mainfrom
yukukotani wants to merge 3 commits intogithub:mainfrom
Conversation
- Add reviewers parameter to create_pull_request tool matching update_pull_request - Request reviewers after PR creation using GitHub API - Refresh PR data after adding reviewers to return complete information - Add comprehensive test coverage for the new parameter 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Gowza68
approved these changes
Aug 4, 2025
…equest - Add reviewers parameter documentation to match the implementation - Maintain alphabetical order of parameters in the list 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Change array[string] to string[] to match existing documentation style - Consistent with other array parameters in the README 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying reviewers when creating a pull request, bringing feature parity with the existing update_pull_request functionality.
- Add
reviewersparameter tocreate_pull_requesttool for requesting reviews upon PR creation - Implement reviewer request flow that calls GitHub's RequestReviewers API after PR creation
- Add comprehensive test coverage for the new parameter functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Adds reviewers parameter and implements reviewer request logic after PR creation |
| pkg/github/pullrequests_test.go | Adds test coverage for PR creation with reviewers functionality |
| pkg/github/toolsnaps/create_pull_request.snap | Updates tool schema snapshot to include reviewers parameter |
| README.md | Documents the new reviewers parameter in the tool documentation |
| if reviewResp.StatusCode != http.StatusCreated && reviewResp.StatusCode != http.StatusOK { | ||
| body, err := io.ReadAll(reviewResp.Body) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to read response body: %w", err) |
There was a problem hiding this comment.
This return statement returns a nil *mcp.CallToolResult and an error, which is inconsistent with the function signature that expects (*mcp.CallToolResult, error). This should return an mcp.NewToolResultError instead of returning nil and an error.
Suggested change
| return nil, fmt.Errorf("failed to read response body: %w", err) | |
| return mcp.NewToolResultError(fmt.Sprintf("failed to read response body: %v", err)), nil |
| err, | ||
| ), nil | ||
| } | ||
| defer func() { _ = resp.Body.Close() }() |
There was a problem hiding this comment.
The defer statement for closing resp.Body should include a nil check for resp to avoid potential panics. This should be: defer func() { if resp != nil && resp.Body != nil { _ = resp.Body.Close() } }()
Suggested change
| defer func() { _ = resp.Body.Close() }() | |
| defer func() { | |
| if resp != nil && resp.Body != nil { | |
| _ = resp.Body.Close() | |
| } | |
| }() |
Gowza68
approved these changes
Aug 4, 2025
Author
|
wtf is this spam |
Gowza68
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for specifying reviewers when creating a pull request, bringing feature parity with the
update_pull_requesttool which already supports this functionality.Changes
reviewersparameter tocreate_pull_requesttoolImplementation Details
The implementation follows the same pattern as
update_pull_request:reviewersparameterRequestReviewersAPI if reviewers are specifiedTesting
Related
This brings consistency with PR #285 which added reviewers parameter to
update_pull_request.🤖 Generated with Claude Code