Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the parameter name from q to query for the search code functionality, completing the migration to more descriptive parameter naming across the codebase.
- Renamed parameter
qtoqueryin the search code tool implementation - Updated all corresponding test cases and assertions to use the new parameter name
- Updated documentation to reflect the parameter name change
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/search.go | Updated parameter definition and extraction from q to query |
| pkg/github/search_test.go | Updated test assertions and test data to use query instead of q |
| pkg/github/toolsnaps/search_code.snap | Updated snapshot test data to reflect the parameter name change |
| README.md | Updated documentation to show query parameter instead of q |
LuluBeatson
approved these changes
Jul 24, 2025
|
Merged |
Closed
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This it the last place where we're using
qinstead ofquery.