Remove redundant param for get_me and update contribution guide#649
Merged
Remove redundant param for get_me and update contribution guide#649
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-unnecessary reason parameter from the get_me tool and updates related documentation and snapshots.
- Removed the
reasonfield from the Go tool definition and its snapshot - Updated README to indicate no parameters are required
- Reformatted the CONTRIBUTING guide’s checklist for clarity
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/context_tools.go | Removed mcp.WithString("reason",…) calls in GetMe |
| pkg/github/toolsnaps/get_me.snap | Cleared out the reason property in the snapshot |
| README.md | Changed parameter list to “No parameters required” |
| CONTRIBUTING.md | Converted hyphenated list to numbered steps and added detail |
Comments suppressed due to low confidence (2)
README.md:553
- [nitpick] Indent the "No parameters required" bullet under the
get_meentry so it correctly nests as a sub-item in the markdown list.
- No parameters required
CONTRIBUTING.md:27
- [nitpick] Indent these hyphenated sub-steps under step 5 to ensure they render as nested list items in the markdown.
- Run linter: `script/lint`
LuluBeatson
reviewed
Jul 7, 2025
CONTRIBUTING.md
Outdated
Comment on lines
27
to
29
| - Run linter: `script/lint` | ||
| - Update snapshots and run tests: `UPDATE_TOOLSNAPS=true go test ./...` | ||
| - Update readme documentation: `script/generate-docs` |
Contributor
There was a problem hiding this comment.
nit: indent these so they appear as nested inside step 5
LuluBeatson
approved these changes
Jul 7, 2025
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
…ub#649) * remove reason param for get_me * updating toolsnap * update contributing * updating tool get_me * add small changes * update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr:
reasonargument forget_metool call.