fix: get_discussion graphQL invalid field#648
Merged
LuluBeatson merged 3 commits intomainfrom Jul 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR fixes the GraphQL query and response handling in get_discussion by removing the invalid state field and replacing the old labels approach with a proper category mapping.
- Removed
statefrom both query and response struct. - Switched from
github.Issuetogithub.Discussionreturn type and updated corresponding fields. - Updated tests to reflect the new
DiscussionCategoryfield instead of labels and state.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/discussions.go | Removed State field, switched to github.Discussion, and mapped Category directly. |
| pkg/github/discussions_test.go | Updated test expectations: changed type to Discussion, removed State, and asserted on DiscussionCategory. |
Comments suppressed due to low confidence (2)
pkg/github/discussions.go:215
- The function doc comment still refers to returning an issue. Please update any surrounding comments or docs to reflect that this now returns a
Discussionstruct rather than anIssue.
discussion := &github.Discussion{
pkg/github/discussions_test.go:270
- [nitpick] Consider using a pointer (
var out *github.Discussion) when unmarshalling JSON into a pointer type; this aligns with yourexpectedpointer and avoids extra dereferencing in assertions.
var out github.Discussion
omgitsads
approved these changes
Jul 7, 2025
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
* rm State which does not exist on type Discussion * update Test_GetDiscussion * use Discussion object instead of Issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug in
get_discussionwhich caused tool error and returned:github.Discussionobject instead ofgithub.IssueBefore with bug
Now fixed: