fix: default empty, nil, or null arguments to empty object to prevent unmarshal error#2689
Open
wibisanabama wants to merge 1 commit into
Open
fix: default empty, nil, or null arguments to empty object to prevent unmarshal error#2689wibisanabama wants to merge 1 commit into
wibisanabama wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2587.
In certain MCP clients, zero-parameter tools (specifically
get_me) are called with theargumentsfield omitted entirely (resulting in anilraw message), empty, or set tonull.Currently,
NewServerToolWithContextHandlerattempts to unmarshalreq.Params.Argumentsdirectly. Unmarshalling anilor empty byte slice in Go causes a JSON error (unexpected end of JSON inputorjson: Unmarshal(nil)), failing the tool call before the handler can execute.Proposed solution
We update the MCP tool handler wrapper in
pkg/inventory/server_tool.goto safely default empty,nil, or"null"arguments to[]byte("{}")before unmarshalling.This ensures that:
How was this verified?
TestNewServerToolWithContextHandler_EmptyArguments_Succeedstopkg/inventory/server_tool_test.goto verify unmarshalling behavior with:nilarguments"""null"arguments{}go test -v ./pkg/inventory/...go test ./...