Remove go-github-mock dependency from repositories_test.go and issues_test.go

[Copilot]

Summary

Completes migration away from github.com/migueleliasweb/go-github-mock by removing it from pkg/github/repositories_test.go and pkg/github/issues_test.go.

Why

Part of ongoing effort to replace external mock library with internal test infrastructure.

What changed

• Removed migueleliasweb/go-github-mock import from repositories_test.go and issues_test.go
• Replaced mock.NewMockedHTTPClient, mock.WithRequestMatchHandler, mock.WithRequestMatch with local equivalents (already defined in helper_test.go)
• Updated pkg/raw/raw_mock.go to define EndpointPattern locally instead of importing from mock library
• Extended normalizeEndpointKey() in helper_test.go to handle raw.EndpointPattern type

MCP impact

• No tool or API changes

Prompts tested (tool changes only)

Security / limits

• No security or limits impact

Lint & tests

• Linted locally with ./script/lint
• Tested locally with ./script/test

Note: 5 tests currently failing with JSON parse error - under investigation. Tests pass on base commit, suggesting subtle mock matching or serialization issue introduced during migration.

Docs

• Not needed

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[JoannaaKL]

@copilot these tests don't even pass, fix them

[Copilot]

Pull request overview

This PR completes the migration away from the external migueleliasweb/go-github-mock library by removing it from repositories_test.go and issues_test.go, building upon the internal test infrastructure already defined in helper_test.go.

Key Changes

• Defined a local EndpointPattern type in pkg/raw/raw_mock.go to replace the external mock library's type
• Extended helper_test.go to handle the new raw.EndpointPattern type in endpoint normalization
• Replaced all mock function calls (mock.NewMockedHTTPClient, mock.WithRequestMatchHandler, mock.WithRequestMatch) with their local equivalents across both test files

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/raw/raw_mock.go	Defines local EndpointPattern struct to replace dependency on external mock library
pkg/github/helper_test.go	Extends normalizeEndpointKey() to handle raw.EndpointPattern type for endpoint matching
pkg/github/repositories_test.go	Migrates all test cases from external mock functions to local equivalents (205 replacements)
pkg/github/issues_test.go	Migrates all test cases from external mock functions to local equivalents (142 replacements)

[Copilot]

The normalizeEndpointKey function now handles raw.EndpointPattern type, but there's potential confusion between the local EndpointPattern (defined at line 582) and raw.EndpointPattern. Consider adding a comment to clarify that raw.EndpointPattern is specifically for raw content API endpoints to improve code clarity.

Suggested change

	return v.Method + " " + v.Pattern
	return v.Method + " " + v.Pattern
	// raw.EndpointPattern is used for raw content API endpoints (via the pkg/raw helpers),
	// which is distinct from the local EndpointPattern used for standard REST API tests.

[bretthowell714-source]

Thanks