Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the get_file_contents tool to treat the path parameter as optional (matching the schema definition) and trims leading slashes from paths to prevent double-slash API calls that result in 404 errors.
Key Changes:
- Changed from
RequiredParamtoOptionalParamfor the path parameter to align handler implementation with schema - Added
strings.TrimPrefix(path, "/")to prevent malformed API paths like/owner/repo/contents//file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Treating
pathparam ofget_file_contentsas optional + trimming leading slash.Why
Param
pathis optional in tool description but in the tool handler we treat it as required parameter and get bunch of failures because LLM doesn't pass this parameter.Trimming leading slash in
pathso that we do not end up calling<owner>/<repo>/contents//<path>which results in 404.MCP impact
Prompts tested (tool changes only)
Tested in MCP inspector.
Security / limits
Lint & tests
./script/lint./script/testDocs