fix: remove unnecessary type arguments in helper_test.go#1608
Closed
SamMorrowDrums wants to merge 1 commit intomainfrom
Closed
fix: remove unnecessary type arguments in helper_test.go#1608SamMorrowDrums wants to merge 1 commit intomainfrom
SamMorrowDrums wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary explicit type arguments from OptionalParamOK function calls in test code, addressing the infertypeargs linter warning. The second type parameter (map[string]any) can be automatically inferred by Go from the function arguments, making its explicit specification redundant.
Key Changes:
- Simplified three
OptionalParamOKcalls by removing the redundant second type parameter - Maintained test functionality while improving code clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary explicit type arguments from
OptionalParamOKcalls inhelper_test.go.Go can infer the second type parameter (
map[string]any) automatically, so specifying it explicitly triggers theinfertypeargslint warning about unnecessary type arguments.Changes
OptionalParamOK[string, map[string]any]→OptionalParamOK[string]OptionalParamOK[bool, map[string]any]→OptionalParamOK[bool]OptionalParamOK[float64, map[string]any]→OptionalParamOK[float64]