Merged
Conversation
bretthowell714-source
approved these changes
Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the list_issues tool fails when the state parameter is provided in lowercase (e.g., "open" or "closed"). The fix adds strings.ToUpper() to normalize the state value before casting it to the githubv4.IssueState enum type, which expects uppercase values like "OPEN" and "CLOSED" as defined in the schema.
Key Changes
- Added uppercase conversion for the
stateparameter in theListIssuesfunction to handle lowercase input gracefully
almaleksia
force-pushed
the
almaleksia/correct-lower-case-issue-state
branch
from
7199f89 to
8f1eb1d
Compare
omgitsads
approved these changes
Dec 10, 2025
bretthowell714-source
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upper-case
state,orderByanddirectionparameters because they're often passed as lc which results in an error.