Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CRUD operations in the GitHub MCP Server to include resource IDs in minimal responses, enhancing client-side resource management. The change extends the MinimalResponse struct to include an ID field alongside the existing URL field.
Key changes:
- Added
IDfield toMinimalResponsestruct for consistent resource identification - Updated all CRUD operations to populate the new ID field using the resource's GitHub ID
- Ensured consistent formatting of IDs across different resource types
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/minimal_types.go | Added ID field to MinimalResponse struct |
| pkg/github/repositories.go | Updated repository creation and fork operations to include ID |
| pkg/github/pullrequests.go | Updated pull request creation and update operations to include ID |
| pkg/github/issues.go | Updated issue creation and update operations to include ID |
| pkg/github/gists.go | Updated gist creation and update operations to include ID |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tonytrg
approved these changes
Sep 10, 2025
nickytonline
pushed a commit
to nickytonline/github-mcp-http
that referenced
this pull request
Oct 4, 2025
* add return ID to crud tools * Update pkg/github/gists.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update pkg/github/gists.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix gist id to string conv --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
MinimalResponsestruct to include anIDfield alongside the existingURLfield. This change ensures that all minimal responses now return both the unique identifier and the URL for created or updated resources, making it easier for clients to reference resources directly.IDfield to theMinimalResponsestruct inpkg/github/minimal_types.go, allowing API responses to include both the resource ID and URL.CreateGist,UpdateGist,CreateIssue,UpdateIssue,CreatePullRequest,UpdatePullRequest,CreateRepository,ForkRepository) to set theIDfield in their minimal responses. [1] [2] [3] [4] [5] [6] [7] [8]Closes: #1071