[log] Add debug logging to workflow pkg files lacking coverage#23492
Merged
[log] Add debug logging to workflow pkg files lacking coverage#23492
Conversation
Add logger declarations and meaningful debug log calls to five workflow package files that had no or minimal logging: - cache_integrity.go: new logger, log policy hash computation, cache key generation, and integrity level ordering - safe_outputs_tools_computation.go: new logger, log enabled tool count - validation_helpers.go: new logger, log mount format parsing and trigger lookup results - mcp_rendering.go: log renderer factory creation and standard renderer construction with key parameters - expression_nodes.go: log inline disjunction rendering term count Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logger.Newdeclarations and meaningfullog.Printf/log.Printcalls to five workflow-package files that had no or minimal debug logging. All log arguments are side-effect-free.Files changed
pkg/workflow/cache_integrity.gocacheIntegrityLog; logs policy-hash computation, sentinel selection, cache-key generation, and integrity-level orderingpkg/workflow/safe_outputs_tools_computation.gosafeOutputsToolsComputationLog; logs when no safe-outputs config is present and the final enabled-tool countpkg/workflow/validation_helpers.govalidationHelpersLog; logs mount-format parse results (success and each failure path) and trigger-lookup outcomepkg/workflow/mcp_rendering.gopkg/workflow/expression_nodes.goQuality checklist
*_test.go) modified"pkg:filename"naming conventionmake buildpasses with no errorsgo build ./...passes with no errors