Skip to content

[log] Add debug logging to workflow pkg files lacking coverage#23492

Merged
pelikhan merged 1 commit intomainfrom
add-debug-logging-workflow-pkg-64f713b038bc52f9
Mar 29, 2026
Merged

[log] Add debug logging to workflow pkg files lacking coverage#23492
pelikhan merged 1 commit intomainfrom
add-debug-logging-workflow-pkg-64f713b038bc52f9

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Adds logger.New declarations and meaningful log.Printf/log.Print calls to five workflow-package files that had no or minimal debug logging. All log arguments are side-effect-free.

Files changed

File Change
pkg/workflow/cache_integrity.go New cacheIntegrityLog; logs policy-hash computation, sentinel selection, cache-key generation, and integrity-level ordering
pkg/workflow/safe_outputs_tools_computation.go New safeOutputsToolsComputationLog; logs when no safe-outputs config is present and the final enabled-tool count
pkg/workflow/validation_helpers.go New validationHelpersLog; logs mount-format parse results (success and each failure path) and trigger-lookup outcome
pkg/workflow/mcp_rendering.go Logs renderer-factory creation parameters and standard-renderer construction
pkg/workflow/expression_nodes.go Logs inline disjunction rendering term count (companion to existing multiline path)

Quality checklist

  • ≤ 5 files modified
  • No test files (*_test.go) modified
  • Each new logger follows "pkg:filename" naming convention
  • Log arguments are literals or already-computed values — no side effects
  • Log messages are meaningful and not duplicated with existing output
  • make build passes with no errors
  • go build ./... passes with no errors

Generated by Go Logger Enhancement ·

  • expires on Mar 31, 2026, 9:31 PM UTC

Add logger declarations and meaningful debug log calls to five workflow
package files that had no or minimal logging:

- cache_integrity.go: new logger, log policy hash computation, cache key
  generation, and integrity level ordering
- safe_outputs_tools_computation.go: new logger, log enabled tool count
- validation_helpers.go: new logger, log mount format parsing and trigger
  lookup results
- mcp_rendering.go: log renderer factory creation and standard renderer
  construction with key parameters
- expression_nodes.go: log inline disjunction rendering term count

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added automation enhancement New feature or request labels Mar 29, 2026
@pelikhan pelikhan merged commit 968ea34 into main Mar 29, 2026
@pelikhan pelikhan deleted the add-debug-logging-workflow-pkg-64f713b038bc52f9 branch March 29, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant