Skip to content

feat: add runs-on-slim for compile-stable framework job runner override#23490

Open
Copilot wants to merge 4 commits intomainfrom
copilot/add-runner-inheritance-mechanism
Open

feat: add runs-on-slim for compile-stable framework job runner override#23490
Copilot wants to merge 4 commits intomainfrom
copilot/add-runner-inheritance-mechanism

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026 •
edited
Loading

Generated framework jobs (activation, pre-activation, safe-outputs, unlock, APM, cache-memory, repo-memory) were hardcoded to ubuntu-slim or ubuntu-latest. Teams on self-hosted or GHES environments had no frontmatter-level way to change this — recompile would overwrite any lock file patches.

Changes

  • New frontmatter field runs-on-slim: top-level string that sets the runner for all framework/generated jobs, persisting across recompile
  • formatFrameworkJobRunsOn(data *WorkflowData): new helper replacing direct formatSafeOutputsRunsOn(data.SafeOutputs) calls across all framework job builders, with explicit precedence:
    1. safe-outputs.runs-on — existing override, unchanged behavior
    2. runs-on-slim — new top-level field
    3. ubuntu-slim — compiled-in default
  • Full lock file coverage: every runs-on field in the compiled lock file is now configurable from the frontmatter, including update_cache_memory, push_repo_memory, and the generic safe-output job builder
  • Schema: runs-on-slim added to main_workflow_schema.json
  • FrontmatterConfig / WorkflowData: RunsOnSlim field wired through parsing and extraction

Example

---
on:
  issues:
    types: [opened]
runs-on-slim: self-hosted   # activation, safe_outputs, unlock, push_repo_memory, etc. all use this runner
---

safe-outputs.runs-on still takes precedence when set, so existing workflows are unaffected.

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI linked an issue Mar 29, 2026 that may be closed by this pull request
Generated jobs lack a compile-stable runner override/inheritance mechanism #23485
Open
@pelikhan
feat: add runs-on-activation frontmatter field for compile-stable fra…
bc9bed3 
…mework job runner override

Add a new top-level `runs-on-activation:` frontmatter field that provides a
compile-stable way to override the runner for all framework/generated jobs
(activation, pre-activation, safe-outputs, unlock, APM, etc.).

Precedence (highest to lowest):
1. safe-outputs.runs-on — existing per-section override (backward compat)
2. runs-on-activation   — new top-level field for all framework jobs
3. DefaultActivationJobRunnerImage — compiled-in default (ubuntu-slim)

This addresses the issue where teams on self-hosted or GHES environments
had to manually patch lock files after each recompile to restore the
runner for generated jobs. The new field persists across recompile as
it lives in the frontmatter source.

Changes:
- compiler_types.go: Add RunsOnActivation field to WorkflowData
- frontmatter_types.go: Add RunsOnActivation to FrontmatterConfig + ToMap()
- compiler_orchestrator_workflow.go: Extract runs-on-activation from frontmatter
- safe_outputs_runtime.go: Add formatFrameworkJobRunsOn() helper
- Update 6 job builders to use formatFrameworkJobRunsOn(data)
- Update JSON schema with runs-on-activation property
- Add tests: TestRunsOnActivationField, TestFormatFrameworkJobRunsOn

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/063d54f7-0f17-4023-82d4-e6efb33f5e0c

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add mechanism for compile-stable runner override in generated jobs feat: add runs-on-activation for compile-stable framework job runner override Mar 29, 2026
Copilot AI requested a review from pelikhan March 29, 2026 21:45
@github-actions github-actions bot mentioned this pull request Mar 29, 2026
Open
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Mar 30, 2026

Rename the field to `runs-on-slim

@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Mar 30, 2026

@copilot Review comments.

Ensure every runs/on field written to the log file is configurable from the prompt file.

@pelikhan
refactor: rename runs-on-activation to runs-on-slim, cover all framew…
256a893 
…ork jobs

- Rename `runs-on-activation` → `runs-on-slim` per reviewer feedback
- Extend formatFrameworkJobRunsOn coverage to all remaining framework
  jobs with previously hardcoded runners:
  - update_cache_memory (cache.go): was ubuntu-latest
  - push_repo_memory (repo_memory.go): was ubuntu-latest
  - buildSafeOutputJob (safe_outputs_jobs.go): was safe-outputs.runs-on only

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9777dcec-c84d-4257-ba9c-af7b97370526

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 30, 2026 •
edited
Loading

Rename the field to `runs-on-slim

Done in 256a893 — renamed to runs-on-slim throughout.

@copilot Review comments.

Ensure every runs/on field written to the log file is configurable from the prompt file.

Done in 256a893. The new runs-on-slim field now controls all framework/generated jobs in the lock file via formatFrameworkJobRunsOn. In addition to the 6 jobs from the original commit, the following were missing and are now covered: update_cache_memory (cache.go), push_repo_memory (repo_memory.go), and the generic buildSafeOutputJob helper used by individual safe-output jobs. Every framework runs-on in the lock file is now configurable from the frontmatter (prompt) file.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 2037456/b411/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE b/gh-aw/pkg/gituenv GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 2037456/b412/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env 2037456/b416/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE b/gh-aw/pkg/mathenv GOMODCACHE go (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha 2037456/b420/_pkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env IUmp/NxNN0_guIdkGOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE 2037456/b420/impghcr.io/github/serena-mcp-server:latest (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility /tmp/go-build1912037456/b414/_pkGOINSECURE -trimpath 64/bin/go -p github.com/githu-C -lang=go1.25 go env -json GO111MODULE r: $owner, name: $name) { hasDiscussionsEnabled } } GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE node (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha bmpm/rdupoT1pVw3GOINSECURE GO111MODULE $name) { hasDiscussionsEnabled } } GOINSECURE GOMOD GOMODCACHE 2037456/b411/impGOPROXY -c k/gh-aw/gh-aw/pkGOSUMDB k/gh-aw/gh-aw/pkGOWORK 64/bin/go GOSUMDB GOWORK 64/bin/go /opt/hostedtoolcrev-parse (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title feat: add runs-on-activation for compile-stable framework job runner override feat: add runs-on-slim for compile-stable framework job runner override Mar 30, 2026
@pelikhan
Copy link
Copy Markdown
Collaborator

pelikhan commented Mar 30, 2026

@copilot use tech-writer agent to update docs

@pelikhan pelikhan marked this pull request as ready for review March 30, 2026 00:48
Copilot AI review requested due to automatic review settings March 30, 2026 00:48
@pelikhan
docs: document runs-on-slim frontmatter field
0b44aa5 
Add documentation for the new `runs-on-slim` top-level frontmatter field
that controls the runner for all framework/generated jobs (activation,
safe-outputs, unlock, APM, etc.).

- self-hosted-runners.md: add 'Configuring the framework job runner' section
- frontmatter.md: rename Run Configuration heading to include runs-on-slim,
  add field to example and explanation
- safe-outputs.md: expand Custom Runner Image section with code example
  and cross-reference to runs-on-slim

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a compile-stable frontmatter override (runs-on-slim) to control the runs-on runner used by framework/generated jobs, avoiding manual lockfile patching being overwritten on recompile.

Changes:

  • Introduces runs-on-slim in frontmatter types, workflow data extraction, and JSON schema.
  • Adds formatFrameworkJobRunsOn(*WorkflowData) helper and switches framework job builders to use it.
  • Regenerates workflow lockfiles to reflect the new default/formatting for affected generated jobs (runs-on: ubuntu-slim).

Reviewed changes

Copilot reviewed 102 out of 102 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/workflow/safe_outputs_runtime.go Adds formatFrameworkJobRunsOn helper with precedence over defaults.
pkg/workflow/safe_outputs_runs_on_test.go Adds tests covering runs-on-slim behavior and helper precedence.
pkg/workflow/safe_outputs_jobs.go Uses formatFrameworkJobRunsOn for generated safe-output jobs.
pkg/workflow/repo_memory.go Uses formatFrameworkJobRunsOn for push_repo_memory.
pkg/workflow/notify_comment.go Uses formatFrameworkJobRunsOn for the conclusion job.
pkg/workflow/frontmatter_types.go Wires RunsOnSlim through FrontmatterConfig and ToMap.
pkg/workflow/compiler_unlock_job.go Uses formatFrameworkJobRunsOn for unlock.
pkg/workflow/compiler_types.go Adds RunsOnSlim to WorkflowData.
pkg/workflow/compiler_safe_outputs_job.go Uses formatFrameworkJobRunsOn for consolidated safe_outputs.
pkg/workflow/compiler_pre_activation_job.go Uses formatFrameworkJobRunsOn for pre_activation.
pkg/workflow/compiler_orchestrator_workflow.go Extracts runs-on-slim from frontmatter into WorkflowData.
pkg/workflow/compiler_apm_job.go Uses formatFrameworkJobRunsOn for APM job.
pkg/workflow/compiler_activation_job.go Uses formatFrameworkJobRunsOn for activation.
pkg/workflow/cache.go Uses formatFrameworkJobRunsOn for update_cache_memory.
pkg/parser/schemas/main_workflow_schema.json Adds runs-on-slim to the workflow schema.
.github/workflows/workflow-health-manager.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/weekly-issue-summary.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/weekly-blog-post-writer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/unbloat-docs.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/test-create-pr-error-handling.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/technical-doc-writer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/super-linter.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/step-name-alignment.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/static-analysis-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/stale-repo-identifier.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-update-cross-repo-pr.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-gemini.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-copilot.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-copilot-arm.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-codex.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/smoke-claude.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/slide-deck-maintainer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/sergo.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/security-review.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/security-compliance.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/scout.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/schema-consistency-checker.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/safe-output-health.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/repository-quality-improver.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/repo-audit-analyzer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/q.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/python-data-charts.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/prompt-clustering-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/pr-triage-agent.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/pr-nitpick-reviewer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/portfolio-analyst.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/poem-bot.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/pdf-summary.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/org-health-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/metrics-collector.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/mcp-inspector.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/lockfile-stats.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/jsweep.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/instructions-janitor.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/grumpy-reviewer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/gpclean.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/go-logger.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/go-fan.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/glossary-maintainer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/github-mcp-tools-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/github-mcp-structural-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/firewall-escape.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/discussion-task-miner.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/developer-docs-consolidator.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/delight.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/deep-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/dead-code-remover.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-testify-uber-super-expert.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-safe-output-optimizer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-repo-chronicle.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-rendering-scripts-verifier.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-performance-summary.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-news.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-mcp-concurrency-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-issues-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-integrity-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-function-namer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-firewall-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-doc-updater.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-doc-healer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-copilot-token-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-compiler-quality.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-community-attribution.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-code-metrics.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-cli-performance.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/daily-architecture-diagram.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-session-insights.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-pr-prompt-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-pr-nlp-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-pr-merged-report.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-cli-deep-research.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/copilot-agent-analysis.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/constraint-solving-potd.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/code-scanning-fixer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/cloclo.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/cli-version-checker.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/claude-code-user-docs-review.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/ci-doctor.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/ci-coach.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/audit-workflows.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/agent-persona-explorer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).
.github/workflows/agent-performance-analyzer.lock.yml Regenerated lockfile runner values (ubuntu-latest → ubuntu-slim where applicable).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/workflow/safe_outputs_runs_on_test.go
Comment on lines +328 to +333
for _, jobPattern := range tt.checkJobPatterns {
jobStart := strings.Index(yamlStr, jobPattern)
if jobStart == -1 {
t.Logf("Job pattern %q not found in lock file (may not be generated for this config)", jobPattern)
continue
}
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TestRunsOnSlimField, missing job patterns are logged and skipped (jobStart == -1). This can let the test pass even if a framework job stops being generated or its ID changes, which is exactly what this test is meant to catch. Consider failing the test when an expected job pattern is not found (or explicitly marking patterns as optional and only skipping those).

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 30, 2026 •
edited
Loading

@copilot use tech-writer agent to update docs

Done in 0b44aa5. Updated three docs:

  • guides/self-hosted-runners.md — new "Configuring the framework job runner" section with example and NOTE callout on precedence
  • reference/frontmatter.md — runs-on-slim: added to the Run Configuration section heading, code example, and prose
  • reference/safe-outputs.md — "Custom Runner Image" expanded from a one-liner to a code block with a cross-reference to runs-on-slim

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh auth status (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pelikhan pelikhan Awaiting requested review from pelikhan

Assignees

@pelikhan pelikhan

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generated jobs lack a compile-stable runner override/inheritance mechanism

3 participants

@pelikhan