-
Notifications
You must be signed in to change notification settings - Fork 141
🔒 Implement markdown security scanner for workflows #15208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsyme
wants to merge
11
commits into
main
Choose a base branch
from
safety
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,694
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
27120a5
reject dodgy workflows
dsyme a110c52
Update pkg/workflow/markdown_security_scanner.go
dsyme 3f5c62e
Update pkg/workflow/markdown_security_scanner.go
dsyme ddfc60e
Update pkg/workflow/markdown_security_scanner.go
dsyme 1329449
Update pkg/workflow/compiler_orchestrator_engine.go
dsyme e0520ad
Update pkg/workflow/markdown_security_scanner.go
dsyme cebd291
reject dodgy workflows
dsyme 9561e2e
Merge branch 'safety' of https://github.com/github/gh-aw into safety
dsyme 94da451
reject dodgy workflows
dsyme cae70ab
Merge branch 'main' of https://github.com/github/gh-aw into safety
dsyme 56c2709
Initial plan (#15225)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ import ( | |
| "github.com/github/gh-aw/pkg/constants" | ||
| "github.com/github/gh-aw/pkg/logger" | ||
| "github.com/github/gh-aw/pkg/tty" | ||
| workflowpkg "github.com/github/gh-aw/pkg/workflow" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. weird keyword, it's not commonly used
dsyme marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
|
|
@@ -395,6 +396,16 @@ func addWorkflowWithTracking(workflow *WorkflowSpec, number int, verbose bool, q | |
| fmt.Fprintln(os.Stderr, console.FormatSuccessMessage(fmt.Sprintf("Read workflow content (%d bytes)", len(sourceContent)))) | ||
| } | ||
|
|
||
| // Security scan: reject workflows containing malicious or dangerous content | ||
| if findings := workflowpkg.ScanMarkdownSecurity(string(sourceContent)); len(findings) > 0 { | ||
| fmt.Fprintln(os.Stderr, console.FormatErrorMessage("Security scan failed for workflow")) | ||
| fmt.Fprintln(os.Stderr, workflowpkg.FormatSecurityFindings(findings)) | ||
| return fmt.Errorf("workflow '%s' failed security scan: %d issue(s) detected", workflowPath, len(findings)) | ||
| } | ||
| if verbose { | ||
| fmt.Fprintln(os.Stderr, console.FormatSuccessMessage("Security scan passed")) | ||
| } | ||
|
|
||
| // Find git root to ensure consistent placement | ||
| gitRoot, err := findGitRoot() | ||
| if err != nil { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.