Fix example in control-jobs-with-conditions#40878
Conversation
There was a problem hiding this comment.
Pull Request Overview
Fixes a rendering issue where a GitHub Actions workflow condition was being displayed as $false instead of the intended expression syntax by properly escaping the expression with Jekyll's {% raw %} directive.
- Added Jekyll raw template directive to prevent expression evaluation in documentation
- Ensures the workflow condition displays correctly as
${{ github.repository == 'octo-org/octo-repo-prod' }}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
@glenthomas Thanks for coming back to fix it! |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
My previous PR (#40865) broke the example. The condition is now displaying as
$false.I didn't realise that the expression needs to be escaped.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Use the
{% raw %}template directive (is this the right way to handle it?Check off the following: