Skip to content

do not merge: testing CI 🤞#39973

Closed
rsese wants to merge 2 commits intomainfrom
rsese-test-no-experimental-types
Closed

do not merge: testing CI 🤞#39973
rsese wants to merge 2 commits intomainfrom
rsese-test-no-experimental-types

Conversation

@rsese
Copy link
Member

@rsese rsese commented Aug 21, 2025

just testing CI don't mind me 🧛

Copilot AI review requested due to automatic review settings August 21, 2025 19:44
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • .github/actions/node-npm-setup/action.yml
  • Dockerfile
  • package.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai or contentType: rai.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is a test of the CI system and makes Node.js version and configuration updates across multiple files. The changes are focused on loosening Node.js version constraints and adding environment configuration.

  • Updates Node.js version requirements to allow newer patch versions
  • Removes specific Node.js version pinning in Docker builds
  • Adds workaround for Node.js experimental strip-types feature

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Simplifies Node.js engine requirement from specific version range to allow all v22 versions
Dockerfile Removes pinned Node.js version installation, allowing latest available version
.github/actions/node-npm-setup/action.yml Adds environment variable to disable experimental strip-types feature

},
"engines": {
"node": "^20 || >=22.0.0 <22.18.0"
"node": "^20 || ^22"
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The Node.js version constraint has been loosened from a specific upper bound to allow all v22 versions. Consider if this change could introduce compatibility issues with newer Node.js versions that haven't been tested. The original constraint ^20 || >=22.0.0 <22.18.0 provided more predictable behavior by excluding untested versions.

Suggested change
"node": "^20 || ^22"
"node": "^20 || >=22.0.0 <22.18.0"

Copilot uses AI. Check for mistakes.
RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git \
&& curl -sL https://deb.nodesource.com/setup_22.x | bash - \
&& apt-get install -y nodejs=22.17.0-1nodesource1 \
&& apt-get install -y nodejs \
Copy link

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the specific Node.js version pin (nodejs=22.17.0-1nodesource1) could lead to non-reproducible builds as different versions may be installed depending on when the image is built. Consider pinning to a specific version or version range to ensure consistent builds across environments.

Suggested change
&& apt-get install -y nodejs \
&& apt-get install -y nodejs=22.17.0-1nodesource1 \

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • .github/actions/node-npm-setup/action.yml
  • .github/workflows/headless-tests.yml
  • .github/workflows/local-dev.yml
  • Dockerfile
  • package.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai or contentType: rai.

@rsese rsese closed this Aug 21, 2025
@github github locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments