Skip to content

Comments

Improve TypeScript Configuration by Enabling Stricter Compiler Options and Code Quality Checks#39485

Closed
NirajDN wants to merge 2 commits intogithub:mainfrom
NirajDN:patch-7
Closed

Improve TypeScript Configuration by Enabling Stricter Compiler Options and Code Quality Checks#39485
NirajDN wants to merge 2 commits intogithub:mainfrom
NirajDN:patch-7

Conversation

@NirajDN
Copy link
Contributor

@NirajDN NirajDN commented Jul 24, 2025

Why:

This PR improves the existing tsconfig.json to enable stricter TypeScript compiler options and code quality checks. These changes help catch potential errors earlier and maintain cleaner, safer code across the codebase.

Closes: N/A (no existing issue, but can create one if needed)

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Enabled noImplicitThis and strictNullChecks for improved type safety.
  • Added noUnusedLocals and noUnusedParameters to catch unused variables and parameters.
  • Retained other existing compiler options for compatibility and performance.

These changes only affect static type checking and do not change runtime behavior.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copilot AI review requested due to automatic review settings July 24, 2025 06:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 24, 2025
@Sharra-writes
Copy link
Contributor

@NirajDN I think our "you can't alter that" bot is only set to run on things from our content folder, because that's generally the only place contributors pull from. But, basically, if it's not in the content folder, we can't accept changes to it. I'm afraid this is another one that we can't accept changes to.

@NirajDN
Copy link
Contributor Author

NirajDN commented Jul 25, 2025

@Sharra-writes No worries at all ,totally understand! 😊
I’m eager to contribute and would love to know which files or areas (especially under the content/ folder or elsewhere) are open for community contributions. Could you please point me in the right direction so I can make a meaningful contribution to the project?

Thanks again for your time and support!

@NirajDN

@Sharra-writes
Copy link
Contributor

@NirajDN Our help wanted label is always a good place to start. I don't know your exact expertise, but a lot of the more technical issues just never get a resolution. Most of them are about Actions, but here's one that has to do with the REST API if that's more your thing.

Just keep in mind that it's the documentation that's open source, not the entire docs site infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants