Update grep replay snapshot for absolute paths#1598
Merged
Conversation
Allow the builtin tools replay snapshot to match grep results that include the normalized workdir path, preserving the existing relative-path variant for older runtime output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the built-in tools replay snapshot to tolerate the new grep output format where matched file paths are rooted at ${workdir} (absolute/normalized) rather than ./, preventing replay/proxy misses in CI (notably the C# SDK non-blocking leg) when the runtime emits the legacy-path-honoring variant.
Changes:
- Add an alternate
conversationsentry to covergrepoutput lines prefixed with${workdir}/data.txt. - Preserve the existing relative-path (
./data.txt) snapshot variant so replay can match both runtime formats.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/builtin_tools/should_search_for_patterns_in_files.yaml | Adds a second full replay conversation capturing ${workdir}-rooted grep output while keeping the existing ./ variant. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
edburns
pushed a commit
that referenced
this pull request
Jun 8, 2026
Allow the builtin tools replay snapshot to match grep results that include the normalized workdir path, preserving the existing relative-path variant for older runtime output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime github/copilot-agent-runtime#9819 now honors the legacy grep
pathargument, so the builtin tools replay can receive grep output rooted at${workdir}instead of./. The C# SDK non-blocking CI leg was missing the cached response for that variant and surfaced repeated proxy 500s.This adds an alternate conversation to
should_search_for_patterns_in_files.yamlfor the normalized absolute-path grep result while keeping the existing relative-path variant. That lets replay match both runtime output formats.Generated by Copilot