Skip to content

Enabling aot on samples with aot support published #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaronpowell wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −5
Open

Enabling aot on samples with aot support published #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cookbook/dotnet/recipe/error-handling.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
// Note: AOT (PublishAot) is enabled by default for this recipe.
// To disable AOT for this sample, you can add the directive:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
#:property PublishAot=false

using GitHub.Copilot.SDK;

Expand Down
1 change: 0 additions & 1 deletion cookbook/dotnet/recipe/managing-local-files.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
// Note: AOT is enabled by default for this recipe.
// To disable AOT (for example, during local development), add:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
#:property PublishAot=false

using GitHub.Copilot.SDK;

Expand Down
1 change: 0 additions & 1 deletion cookbook/dotnet/recipe/multiple-sessions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// Note: AOT is enabled by default. To disable AOT for this recipe, add:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
using GitHub.Copilot.SDK;

Expand Down
1 change: 0 additions & 1 deletion cookbook/dotnet/recipe/persisting-sessions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// Note: AOT (PublishAot) is enabled by default for this recipe.
// To disable AOT, add the following directive above:
// #:property PublishAot=false

Copilot uses AI. Check for mistakes.
using GitHub.Copilot.SDK;

Expand Down
1 change: 0 additions & 1 deletion cookbook/dotnet/recipe/pr-visualization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#:project ../../../dotnet/src/GitHub.Copilot.SDK.csproj
#:property PublishAot=false

Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#:property PublishAot=false was removed here, but cookbook/dotnet/recipe/README.md still says each recipe includes that directive to disable AOT. Please update the README (and/or add a short note in these recipes) so users understand AOT is now enabled by default and how to opt out if needed.

Suggested change
// NOTE: This recipe publishes with Native AOT enabled by default.
// To disable AOT for this recipe (for example, if you hit platform or tooling
// limitations), add the following directive at the top of this file:
//
// #:property PublishAot=false
//
// This overrides the default and publishes a non-AOT binary instead.

Copilot uses AI. Check for mistakes.
using System.Diagnostics;
using GitHub.Copilot.SDK;
Expand Down
Loading