C#: Add models as data tests for compound assignment operators.#21989
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds C# external-model test coverage for compound assignment operator overloads by introducing summary models for += (including checked context) and exercising them in the existing external-models dataflow test.
Changes:
- Added external summary models for
op_AdditionAssignmentandop_CheckedAdditionAssignmentonMy.Qltest.N. - Added a new
My.Qltest.Ntest type usingoperator +=/operator checked +=plus call sites that should produce taint flow. - Regenerated the corresponding
.expectedoutput to include the new models and flow paths.
Show a summary per file
| File | Description |
|---|---|
| csharp/ql/test/library-tests/dataflow/external-models/ExternalFlow.ext.yml | Adds two new summary model rows for compound assignment operator overloads (+= and checked +=). |
| csharp/ql/test/library-tests/dataflow/external-models/ExternalFlow.expected | Updates expected model list and provenance-path graph output to reflect the new operator tests. |
| csharp/ql/test/library-tests/dataflow/external-models/ExternalFlow.cs | Introduces N with compound assignment operators and two test methods that drive the modeled taint flow into Sink. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
hvitved
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.