Skip to content

Rust: Avoid unnecessary constraint satisfaction #21172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paldepind wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Draft

Rust: Avoid unnecessary constraint satisfaction #21172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions rust/ql/lib/codeql/rust/internal/typeinference/Type.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,23 @@ final class ImplTypeAbstraction extends TypeAbstraction, Impl {
}
}

private predicate idDynTraitTypeRepr(@dyn_trait_type_repr x, @dyn_trait_type_repr y) { x = y }

private predicate idOfDynTraitTypeRepr(@dyn_trait_type_repr x, int y) =
equivalenceRelation(idDynTraitTypeRepr/2)(x, y)

private int idOfDynTraitTypeRepr(DynTraitTypeRepr node) {
idOfDynTraitTypeRepr(Synth::convertAstNodeToRaw(node), result)
}

/** Holds if `dt` is the canonical dyn trait type abstraction for `trait`. */
private predicate canonicalDynTraitTypeAbstraction(DynTraitTypeRepr dt, Trait trait) {
dt = min(DynTraitTypeRepr d | d.getTrait() = trait | d order by idOfDynTraitTypeRepr(d))
}

final class DynTypeAbstraction extends TypeAbstraction, DynTraitTypeRepr {
DynTypeAbstraction() { canonicalDynTraitTypeAbstraction(this, this.getTrait()) }

override TypeParameter getATypeParameter() {
result = any(DynTraitTypeParameter tp | tp.getTrait() = this.getTrait()).getTraitTypeParameter()
}
Expand Down