Make compile-queries.yml sharded based on language
#21169
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
shard-compile-queries
branch
from
0454861 to
5518795
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the compile-queries.yml workflow to run query compilation in parallel shards based on language, improving performance by allowing each language to run independently in a matrix strategy. For pull requests, it detects which languages have changes and only runs compilation for those languages, while for pushes to main/rc branches, it runs all languages.
Changes:
- Added a new
detect-changesjob that determines which languages have changes in a PR or runs all languages for main/rc branch pushes - Modified
compile-queriesjob to use a matrix strategy based on detected languages - Updated cache keys, formatting checks, and compilation commands to be language-specific
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/compile-queries.yml | Implements sharded compilation by language with change detection for PRs |
| swift/ql/lib/codeql/swift/dataflow/internal/FlowSummaryImpl.qll | Adds a test comment (to be reverted per PR description) |
| rust/ql/lib/codeql/rust/internal/typeinference/BlanketImplementation.qll | Adds an extra period to a comment (to be reverted per PR description) |
Comments suppressed due to low confidence (1)
.github/workflows/compile-queries.yml:39
- When the
languagesarray is empty, the expansion of"${languages[@]}"may cause issues in some shell configurations. Consider using${languages[@]+"${languages[@]}"}or adding a conditional check to explicitly set an empty array when no languages are detected.
echo "languages=$(jq -c -n '$ARGS.positional' --args "${languages[@]}")" >> $GITHUB_OUTPUT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * Holds if the argument type `at` does _not_ satisfy the first non-trivial blanket | ||
| * constraint of `impl`. | ||
| * constraint of `impl`.. |
There was a problem hiding this comment.
Corrected double period '..' to single period '.' at end of comment.
Suggested change
| * constraint of `impl`.. | |
| * constraint of `impl`. |
redsun82
previously approved these changes
Jan 15, 2026
hvitved
force-pushed
the
shard-compile-queries
branch
from
5518795 to
b4bbafa
Compare
jketema
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vibe coded a solution to make this PR check hopefully much faster.
I'll revert the two dummy commits before merging.