Skip to content

Add tests for getCredentials with multiple goproxy_servers and maven_…#3799

Open
mario-campos wants to merge 2 commits intomainfrom
mario-campos/test-multiple-registries
Open

Add tests for getCredentials with multiple goproxy_servers and maven_…#3799
mario-campos wants to merge 2 commits intomainfrom
mario-campos/test-multiple-registries

Conversation

@mario-campos
Copy link
Copy Markdown
Contributor

@mario-campos mario-campos commented Apr 2, 2026

This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) are parsed and reported appropriately. While one additional test would be sufficient to test this multi-registry use-case, I thought two tests across two languages offered a bit more safety.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - I expect a PR check to fail if these tests are implemented incorrectly.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mario-campos mario-campos requested a review from a team as a code owner April 2, 2026 16:05
Copilot AI review requested due to automatic review settings April 2, 2026 16:05
@github-actions github-actions bot added the size/S Should be easy to review label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds unit test coverage to ensure start-proxy’s getCredentials correctly returns multiple registry configurations of the same type for a given language.

Changes:

  • Added a test verifying KnownLanguage.go returns all configured goproxy_server entries (and still includes git_source for Go).
  • Added a test verifying KnownLanguage.java returns all configured maven_repository entries (and filters out non-Java registry types).

@mario-campos mario-campos force-pushed the mario-campos/test-multiple-registries branch from 30f8fba to a9a28d0 Compare April 2, 2026 16:34
@mario-campos mario-campos requested a review from mbg April 2, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Should be easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants