Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Jan 19, 2026

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner January 19, 2026 18:55
Copilot AI review requested due to automatic review settings January 19, 2026 18:55
@github-actions github-actions bot added the size/XS Should be very easy to review label Jan 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the concurrency settings for PR check workflows by including workflow input parameters in the concurrency group name. This allows workflows with different input combinations to run in parallel while ensuring that workflows with the same inputs and ref are properly grouped for cancellation or queuing.

Changes:

  • Modified the Python generator script to append all workflow inputs to the concurrency group name
  • Updated the cancel-in-progress expression (added redundant || false clause)
  • Regenerated all 61 workflow files with the new concurrency group naming pattern

Reviewed changes

Copilot reviewed 56 out of 56 changed files in this pull request and generated 3 comments.

File Description
pr-checks/sync.py Updated concurrency group generation to include workflow input values; modified cancel-in-progress expression
.github/workflows/__*.yml (61 files) Auto-generated workflow files reflecting the new concurrency group naming pattern with input values

redsun82
redsun82 previously approved these changes Jan 21, 2026
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for this!

@mbg mbg enabled auto-merge January 21, 2026 12:41
@mbg mbg merged commit 4325937 into main Jan 21, 2026
252 checks passed
@mbg mbg deleted the mbg/ci/fix-concurrency-ignores-inputs branch January 21, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants