Add Azure infrastructure skills (Landing Zone, WAF Review, Implementa…

[rajesh-ms]

…tion Patterns, Assessment)

Pull Request Checklist

• I have read and followed the CONTRIBUTING.md guidelines.
• My contribution adds a new instruction, prompt, agent, or skill file in the correct directory.
• The file follows the required naming convention.
• The content is clearly structured and follows the example format.
• I have tested my instructions, prompt, agent, or skill with GitHub Copilot.
• I have run npm start and verified that README.md is up to date.

---

Description

---

Type of Contribution

• New instruction file.
• New prompt file.
• New agent file.
• New collection file.
• New skill file.
• Update to existing instruction, prompt, agent, collection or skill.
• Other (please specify):

---

Additional Notes

---

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

[Copilot]

Pull request overview

This PR introduces several Azure infrastructure-focused skills and supporting reference material for the Well-Architected Framework (WAF), landing zone design, and implementation patterns in Bicep/Terraform/CI.

Changes:

• Add azure-waf-review skill with deep-dive reference content for the five WAF pillars (reliability, security, cost, operations, performance) targeted at Azure workloads.
• Add azure-waf-assessment skill with a structured question bank, scoring guide, and report template for conducting guided WAF assessments.
• Add azure-landing-zone-architect and azure-infra-patterns skills with detailed references on landing zone identity, networking, governance, security, and IaC implementation patterns (Bicep, Terraform, CI/CD, naming).

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
skills/azure-waf-review/SKILL.md	Defines the azure-waf-review skill and links to WAF pillar reference docs to support architecture reviews.
skills/azure-waf-review/references/security.md	Provides detailed Azure security/WAF guidance to be used by the review skill.
skills/azure-waf-review/references/reliability.md	Documents Azure reliability and DR design patterns for use in WAF reviews.
skills/azure-waf-review/references/performance.md	Captures performance and scaling best practices for Azure workloads.
skills/azure-waf-review/references/operations.md	Describes DevOps, monitoring, and incident management practices under the operational excellence pillar.
skills/azure-waf-review/references/cost.md	Provides Azure cost optimization patterns and sample configurations.
skills/azure-waf-assessment/SKILL.md	Defines the azure-waf-assessment guided Q&A assessment skill and ties it to supporting references.
skills/azure-waf-assessment/references/questions.md	Supplies a structured WAF question bank for use during assessments.
skills/azure-waf-assessment/references/scoring-guide.md	Defines maturity levels and scoring rules across all WAF pillars.
skills/azure-waf-assessment/references/report-template.md	Provides a reusable report template to document WAF assessment outcomes.
skills/azure-landing-zone-architect/SKILL.md	Introduces the azure-landing-zone-architect skill for landing zone/platform design and links to reference docs.
skills/azure-landing-zone-architect/references/security.md	Details a security baseline (Defender, network security, data protection, SecOps) for Azure landing zones.
skills/azure-landing-zone-architect/references/networking.md	Documents hub-spoke/Virtual WAN topologies, connectivity, DNS, and IP planning for landing zones.
skills/azure-landing-zone-architect/references/identity.md	Describes tenant, RBAC, PIM, hybrid identity, and Conditional Access design for landing zones.
skills/azure-landing-zone-architect/references/governance.md	Covers management groups, subscription patterns, policy strategy, naming/tagging, and cost management.
skills/azure-infra-patterns/SKILL.md	Defines the azure-infra-patterns skill that consolidates code-level IaC implementation patterns.
skills/azure-infra-patterns/references/bicep.md	Provides Bicep module/parameter/loop patterns and common resource examples (storage, Key Vault, RBAC, diagnostics).
skills/azure-infra-patterns/references/terraform.md	Documents Terraform provider, state, module, and common Azure resource patterns.
skills/azure-infra-patterns/references/cicd.md	Adds CI/CD workflow patterns for Bicep/Terraform using GitHub Actions and Azure DevOps.
skills/azure-infra-patterns/references/naming.md	Defines Azure-wide naming conventions, prefixes, abbreviations, and code helpers for Bicep/Terraform.

[Copilot]

In this secure parameter example, adminPassword is defined twice and the az.getSecret(...) call is not valid Bicep syntax for a .bicepparam file, so this snippet would not compile if copied as-is. Consider showing a single @secure() parameter here and either removing the pseudo az.getSecret line or replacing it with a realistic pattern (for example, explaining that secrets are injected via deployment tooling or Key Vault references, not an az function call inside Bicep).

Suggested change

	@secure()
	param adminPassword string
	// Reference from Key Vault in parameter file
	param adminPassword = az.getSecret('<subscription>', '<rg>', '<vault>', '<secret>')
	// main.bicep
	@secure()
	param adminPassword string
	// Secure value is supplied at deployment time (for example via a parameter file,
	// pipeline variable, or Key Vault reference), not hard-coded in the template.

[Copilot]

The description references a skill named azure-architecture-waf-review, but the actual skill defined in this repo is azure-waf-review, so this pointer will confuse users. Please update the reference to use the correct skill name so that readers can easily find the follow-up review skill.

Suggested change

	for assessments. For interpretation of findings, use azure-architecture-waf-review.
	for assessments. For interpretation of findings, use azure-waf-review.

[Copilot]

For new skills, the repository guidelines expect entries to be added to docs/README.skills.md, but the new azure-waf-review, azure-waf-assessment, azure-landing-zone-architect, and azure-infra-patterns skills are not currently listed there. Please add entries for these skills to docs/README.skills.md so they appear in the skills index.

[Copilot]

The description field in the front matter is using a block scalar (|) instead of a single-quoted string, which diverges from the SKILL.md conventions used elsewhere in the repo. To keep SKILL metadata consistent, consider switching this to a single-quoted description value on one line.

[Copilot]

The description field in the front matter is using a block scalar (|) instead of a single-quoted string, which diverges from the SKILL.md conventions used elsewhere in the repo. To keep SKILL metadata consistent, consider switching this to a single-quoted description value on one line.

[Copilot]

The description field in the front matter is using a block scalar (|) instead of a single-quoted string, which diverges from the SKILL.md conventions used elsewhere in the repo. To keep SKILL metadata consistent, consider switching this to a single-quoted description value on one line.

[Copilot]

The description field in the front matter is using a block scalar (|) instead of a single-quoted string, which diverges from the SKILL.md conventions used elsewhere in the repo. To keep SKILL metadata consistent, consider switching this to a single-quoted description value on one line.

[aaronpowell]

Can you run the update script to ensure the readmes are updated

[aaronpowell]

Please follow the contributing guide and target PR's against the staged branch, not main. You can do this with the GitHub CLI:

gh pr edit 603 --base staged