Potential fix for pull request finding#1992
Open
Ahamed-X wants to merge 56 commits into
Open
Conversation
* Make publish branches append-only Transition the publish workflow so main and marketplace are updated by append-only commits built on top of each branch's current tip instead of force-pushing source-branch history.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix worktree path handling in publish workflow Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Handle publish branch tip drift before atomic push Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Clarify publish drift error details Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * Improve concurrent publish drift message Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
* new instruction exclude-prompt-data.instructions * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* stuffed up and plugins are in staged * fixing readme * fixing plugin file
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…otnet-1.0.1146-preview1 Update modernize-dotnet plugin to 1.0.1146-preview1
* fix(pm-skills): use plain tag name for ref, not refs/tags/
`apm install pm-skills@awesome-copilot` invokes `git clone --depth=1 --branch=<ref>` against the source repo. `git clone --branch` rejects `refs/tags/v2.1.0` ("Remote branch not found in upstream origin") and only accepts the plain tag name.
Matches the convention used by the other entries in this file - `chrome-devtools-plugin` uses `chrome-devtools-mcp-v1.0.1`, `ai-ready` uses a SHA. `pm-skills` was the only entry with the `refs/tags/` prefix, inherited from the placeholder example in the external-plugin issue form.
Tested locally: with the fix applied, `apm install pm-skills@awesome-copilot --target claude` resolves cleanly (12 skills + MCP server + 2 hooks integrated).
Original submission: github#1767 / github#1770
* fix: regenerate marketplace.json after pm-skills ref fix
The previous force-push (7fbf75a) updated plugins/external.json only.
.github/plugin/marketplace.json is a derived artifact regenerated by
`npm start` and must be kept in sync. The Validate README.md workflow
detected the mismatch and failed.
Ran `npm ci && npm start` locally; produces a single 1-line update to
marketplace.json matching the plugins/external.json change.
* Enhance Ember with trio from-the-other-side skills * Regenerate plugin index after build * Address Ember README review consistency feedback
Pass an explicit 'en' locale to localeCompare for instruction title sorting in update-readme.mjs. Previously the default OS locale was used, causing String.prototype.localeCompare to produce different orderings on Windows vs Ubuntu (affecting characters like Korean and Japanese CJK titles), which made the validate-readme CI workflow non-deterministic. Fixes the root cause of the locale-dependent sort instability.
…github#1857) Set-ItResult -Skipped/-Inconclusive throws internally to end the It block, so code after it does not run and a trailing return is unreachable. Documenting this prevents the recurring suggestion to add a redundant return after Set-ItResult. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat: add conventional-branch skill Add a new agent skill for creating Git branches following the Conventional Branch specification. The skill covers branch naming rules, valid/invalid examples, type prefixes (feature/, bugfix/, hotfix/, release/, chore/), trunk branch detection, and a step-by-step workflow for branch creation. The skill complements the existing conventional-commit skill and references the specification at https://conventional-branch.github.io. * fix: use explicit numbered workflow steps in conventional-branch skill Replace markdown heading-based workflow steps (### 1., ### 2.) with explicit 'Step N — Title' format for better agent comprehension.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…b#1860) * Add external plugin quality gates and override flow Introduce a dedicated reusable quality-gates workflow for external plugin submissions and wire intake/rerun orchestration to consume its results. Add quality-aware intake state handling, including a submitter-fix blocker state and richer intake comments. Also add a maintainer /mark-ready-for-review command workflow for explicit overrides, update related approval-label handling, and document the new external plugin review flow in CONTRIBUTING and AGENTS guidance. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: use specific auth/network patterns in classifySmokeFailure Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * refactor: hoist INFRA_ERROR_PATTERNS to module level, fix timeout regex Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> * fix: install Copilot CLI in external-plugin-quality-gates workflow Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the Bash namecheap.sh with a stdlib-only Python CLI (namecheap.py) that resolves all Copilot PR review feedback: - Cache the public IP once per run instead of per request - Build API requests in-process via urllib so the API key never appears in process argv or shell history - Broaden multi-part TLD detection (co.uk, com.au, etc.) and document the limitation - Allow setup to update existing stored credentials - Stop soliciting the API key via chat; use terminal getpass or env vars - Remove non-portable Bash constructs (inline local, grep -oP) Also normalize domain casing, preserve MX priority 0, accept case-insensitive record types, and handle mixed-case email-forwarding attributes. Update SKILL.md and regenerate the skills README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Generate extensions data, add the extensions listing route/navigation, and include install URL copy actions pinned to the build commit SHA. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…dernize-dotnet-1.0.1152-preview1
* React to rerun intake comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * some whitespace fixes * more whitespace fixes --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: Add external plugins Kanban board canvas extension - Create interactive Kanban board showing external plugin submission issues - Display issues in columns based on labels: 'requires-submitter-fixes', 'ready-for-review', 'approved', 'rejected' - Support drag-and-drop state transitions between columns - Show PR links for approved issues via [Generated PR](url) pattern in issue body - Display issue summaries with numbers and titles - Use app theme variables for visual integration - Implement demo mode with example issues for consistent testing The canvas includes: - HTTP server with /api/issues endpoint for issue fetching - Drag-and-drop UI with vanilla JavaScript - Responsive HTML/CSS Kanban layout - Auto-refresh on drag operations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: Add issue detail modal to Kanban board canvas - Click any issue card to view full details in a modal - Modal shows issue description, creation/update dates, labels, and PR link - Displays formatted dates and color-coded label badges - Modal can be closed via X button or clicking outside - Drag-and-drop still works on issue cards - Added hover effects to issue cards for better interactivity Demo data now includes issue body descriptions, created_at, and updated_at timestamps for realistic display. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: Integrate real external plugin issues from repository - Replaced hard-coded demo data with live gh CLI integration - Attempts to fetch actual issues using 'gh issue list --label external-plugin' - Tries multiple gh installation paths for Windows compatibility - Falls back to demo data if gh CLI isn't accessible from extension subprocess - Demo data now contains real external plugin issue titles from repository - Maintains full functionality (Kanban board, drag-drop, modal details, PR links) Note: gh CLI integration may require environment configuration on Windows. The extension gracefully degrades to accurate demo data when live integration unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Implement external plugins Kanban board canvas with GitHub API integration - Created external-plugins-board canvas extension with HTTP loopback server - 4-column Kanban board layout (requires-submitter-fixes, ready-for-review, approved, rejected) - Fetches real issues from github/awesome-copilot repository via GitHub REST API - Click issues to view full details in modal (title, description, dates, labels, PR links) - Drag-and-drop support for state transitions (future: update labels via API) - Responsive design with theme variable integration for light/dark mode - No hard-coded demo data - displays actual repository data Resolved subprocess execution limitation: - Extension subprocess is sandboxed and cannot execute system binaries (gh, cmd.exe, powershell.exe) - Solution: Use GitHub REST API directly instead of gh CLI subprocess execution - API calls work perfectly from within restricted subprocess environment Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Render issue body as markdown in board modal - add marked dependency for markdown parsing\n- render issue body HTML in the modal\n- style markdown elements for readable theme-aware output\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cation (github#1952) The install smoke gate was hardcoding .github/plugin/plugin.json as the expected manifest path after copilot plugin install, which caused a false ail for plugins whose manifests live at plugin.json (root) or .plugins/plugin.json instead of the Copilot CLI convention. Replace the hardcoded path with a call to the existing indPluginJson() helper that already probes all three candidate locations in priority order. Separate the 'install directory missing' check from 'no manifest found' so error messages surface the actual root cause. Also fix a .plugin/ → .plugins/ typo in EXTERNAL_PLUGIN_ROOT_MANIFEST_PATHS (external-plugin-validation.mjs) which caused the error message shown to submitters to reference a path that indPluginJson never actually checks. Add cross-reference comments on both constants so they stay in sync. Closes: reported in issue github#1837 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ithub#1765) * feat(instructions): add java junit5 assertions best practices * feat(instructions): add JUnit 5 assertions best practices guide
* chore(deps, docs): bump marketplace version to 1.46.0 - Refine execution priority guidance in agent documentation - Imrpvoe discovery guidance - Improve context cache guidance - Add script usage guidelines to agent documentation - Simplify agent input references * feat: bump marketplace version to 1.47.0 and enhance agent workflows - Add Bug‑Fix Mode with validation gate for `debugger_diagnosis` tasks - Expand allowed task types to include `research` - Reduce subagent concurrency limit from 4 to 2 - Update design validation handling for flagged tasks - Update marketplace plugin version reference to 1.47.0 * chore: bump marketplace version to 1.48.0 and refine agent context envelope workflow documentation - Enhance the Init section in gem-browser-tester.agent.md, gem-code-simplifier.agent.md, and gem-critic.agent.md with detailed context envelope handling, active context treatment, and reuse_notes trust/verification logic. - Add explicit steps for safe assumption, verification before use, and controlled re‑reading of context notes. * chore: refine verification of symbol usages before modifying shared components * chore(marketplace): bump version to 1.50.0; refactor(gem-browser-tester): simplify workflow steps * chore(docs): simplify Phase 0 task classification and streamline initialization * chore: Merges teps for batching * feat: Enhcanc esuport for trivial/ low complex tasks * chore: bump version to 1.56.0 and add config settings for visual regression, devops approvals, and orchestrator complexity * chore: fix toc links * chore: Remove emojis from headings * chore: Update readme * chore: Enforce orchestration * chore: clarify orchestrator role and bump version to 1.59.0 * chore: bump version to 1.61.0 and refine agent documentation
* Add scala-spark instructions * Add scala-spark instructions - readme * Add scala-spark instructions-readme-updated --------- Co-authored-by: Kapil Samant <kapilsamant@microsoft.com>
* aws plugin and adding few more aws agents * updating the agent def * fixed around skill validator results. --------- Co-authored-by: Preyas Prakasan <preyasprakasan@Preyass-MacBook-Pro.local>
Adds og:image:width and og:image:height to the global head so LinkedIn (and friends) reliably render the large preview card instead of a tiny thumbnail. The image and the rest of the Open Graph tags were already in good shape, so this is the missing piece. Also adds a website README documenting how the cards work and the gotchas. Co-authored-by: GeekTrainer <GeekTrainer@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Separate re-review commands from intake/approval pipeline - Removed /re-review-* from external-plugin-command-router.yml - Created external-plugin-rereview-command.yml with separate concurrency - Each pipeline maintains independent per-issue serialization - Router: /approve, /reject, /mark-ready-for-review, /rerun-intake - Re-review: /re-review-keep, /re-review-needs-changes, /re-review-remove Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Scope router workflow token permissions - Set default router workflow permissions to contents:read + issues:write - Move elevated contents/pull-requests write permissions to approval-command only - Keep approval command behavior unchanged while reducing privileges for rerun-intake and mark-ready paths Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Align router concurrency with intake workflow - Update command router to reuse the intake concurrency group key - Preserve queueing behavior for comment commands Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Introduce a PR risk scanner script plus two workflows: one to scan changed files and upload findings, and one to upsert a sticky PR comment with a summary table and findings. This adds non-blocking supply-chain risk visibility for agentic contributions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reject absolute paths, enforce repo-root containment after resolution, and tighten unpinned-version detection to dependency/version contexts to avoid markdown noise. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
main, but PRs should target staged.
The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.
You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1992 --base staged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot Autofix powered by AI 175728472+Copilot@users.noreply.github.com