Add AccessLint scan engine#241
Open
kzhou314 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AccessLint as an additional built-in scan engine in the find GitHub Action, alongside Axe, with selection controlled via the scans input while preserving the default behavior (Axe-only when scans is omitted).
Changes:
- Introduces an AccessLint scan path (
runAccesslintScan) and wires it intofindForUrlbased on a new scans context flag. - Updates
scansparsing logic to treataxeandaccesslintas core engines and everything else as plugin names. - Adds dependencies and test coverage for the new scan engine, plus updates action input documentation.
Show a summary per file
| File | Description |
|---|---|
| .github/actions/find/tests/findForUrl.test.ts | Adds tests ensuring AccessLint runs when selected and composes with Axe/plugins. |
| .github/actions/find/src/scansContextProvider.ts | Extends scan-selection context to include AccessLint and adjusts plugin detection. |
| .github/actions/find/src/findForUrl.ts | Adds AccessLint scan execution and maps AccessLint violations into findings. |
| .github/actions/find/package.json | Adds @accesslint/playwright and @playwright/test dependencies. |
| .github/actions/find/package-lock.json | Locks new dependencies and updates Playwright resolution. |
| .github/actions/find/action.yml | Documents new core engine behavior for the scans input. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Files not reviewed (1)
- .github/actions/find/package-lock.json: Generated file
- Files reviewed: 5/6 changed files
- Comments generated: 5
…nd pass UrlConfig in tests) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility/issues/10666
Adds AccessLint as a built-in scan engine alongside Axe. Opt in via the
scansinput, e.g.["axe", "accesslint"]. With noscansinput the default stays axe-only.