Attempts to fix site-with-errors tests timing out

[lindseywild]

No description provided.

[Copilot]

Pull request overview

Adjusts test expectations and retry behavior to reduce flakiness/timeouts when validating cached results for the site-with-errors scenario.

Changes:

• Make pullRequest optional in cached Result test typing.
• Update site-with-errors test to avoid assuming every cached result contains a PR URL; only fetch PRs when present.
• Increase default retry attempts in the fix GitHub Action retry helper.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File	Description
tests/types.d.ts	Makes Result.pullRequest optional to reflect real cache contents.
tests/site-with-errors.test.ts	Stops unconditionally reading/fetching PR URLs; fetches PRs only when present and adds a PR-count assertion.
.github/actions/fix/src/retry.ts	Raises default retry attempts for exponential-backoff retries.

Comments suppressed due to low confidence (1)

tests/site-with-errors.test.ts:150

• The filter ensures pullRequest?.url exists, but TypeScript can’t narrow the type across this chain, so the code relies on pullRequest! non-null assertions. Consider using a type-predicate filter (or filtering on pullRequest itself) to eliminate the non-null assertions and keep the code type-safe if this logic changes later.

        results
          .filter(({pullRequest}) => !!pullRequest?.url)
          .map(async ({pullRequest}) => {
            const pullRequestUrl = pullRequest!.url
            const {owner, repo, pullNumber} =

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Increasing the default maxAttempts from 6 to 10 significantly increases worst-case retry time with the current exponential backoff (baseDelay 2s, capped at 30s), potentially adding multiple minutes of waiting and worsening timeouts in the action. Consider keeping the default smaller and/or passing a higher maxAttempts only at the call site(s) that need it, or making it configurable via input/env so retries don’t unexpectedly extend runtimes.

Suggested change

	maxAttempts = 10,
	maxAttempts = 6,