Merge pull request #321 from github-for-unity/enhancements/git-lfs-230

Upgrading to Git LFS 2.3.0

Author: shana

src/GitHub.Api/Installer/GitInstaller.cs

@@ -6,8 +6,8 @@ namespace GitHub.Unity
 {
     class GitInstaller : IGitInstaller
     {
-        public const string WindowsGitLfsExecutableMD5 = "7cfa21e5e9f9819a7cb0c317b0be1c5b";
-        public const string MacGitLfsExecutableMD5 = "54f586df05a4b80feae4fabed10d8e95";
+        public const string WindowsGitLfsExecutableMD5 = "ef51379a06577bcdeef372d297d6cd7f";
+        public const string MacGitLfsExecutableMD5 = "2b324cbfbb9196cf6a3c0a0918c434c7";
 
         private const string PortableGitExpectedVersion = "f02737a78695063deace08e96d5042710d3e32db";
         private const string PackageName = "PortableGit";

src/GitHub.Api/PlatformResources/linux/git-lfs.zip

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:09781a02cb8ef9ff0abaa9e669ae5c0b94166a49fdb45c75a7604f98d772f71a
-size 2477147
+oid sha256:c86ab0b766e2d523ba2bf2ae427fe755e553989f7160217380b0f4dead7b802b
+size 2631425

src/GitHub.Api/PlatformResources/mac/git-lfs.zip

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:749d4f91993eb4526f3667e524b9902e2d909fcd2a9ea8ee6025177eb16817f0
-size 2736142
+oid sha256:8b30e08751549f70f052eda49e0e2875ce006c98d013a17c46943b830f22e867
+size 2780647

src/GitHub.Api/PlatformResources/windows/git-lfs.zip

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9aac2fdc3d1527ee6c796e4364eafeacbbeefc38714a4df63fb7c8a1ec7bcff5
-size 2596848
+oid sha256:64b2e9186ff553f2e4afe4db38b21d27e3dde08f3347ff8ea88c667dfcefb92f
+size 2807324

src/tests/IntegrationTests/Git/GitSetupTests.cs

@@ -69,7 +69,7 @@ public async Task InstallGit()
 
 
         [Test]
-        public void VerifyGitLfsBundle()
+        public void VerifyWindowsGitLfsBundle()
         {
             var environmentPath = NPath.CreateTempDirectory("integration-test-environment");
 
@@ -84,7 +84,27 @@ public void VerifyGitLfsBundle()
             gitLfsPath.Exists().Should().BeTrue();
 
             var calculateMd5 = NPath.FileSystem.CalculateMD5(gitLfsPath);
-            Assert.IsTrue(string.Compare(calculateMd5, GitInstaller.WindowsGitLfsExecutableMD5, true) == 0);
+            calculateMd5.ToLower().Should().Be(GitInstaller.WindowsGitLfsExecutableMD5.ToLower());
+        }
+
+
+        [Test]
+        public void VerifyMacGitLfsBundle()
+        {
+            var environmentPath = NPath.CreateTempDirectory("integration-test-environment");
+
+            var gitLfsPath = environmentPath.Combine("git-lfs");
+            gitLfsPath.Exists().Should().BeFalse();
+
+            var inputZipFile = SolutionDirectory.Combine("PlatformResources", "mac", "git-lfs.zip");
+
+            var fastZip = new FastZip();
+            fastZip.ExtractZip(inputZipFile, environmentPath, null);
+
+            gitLfsPath.Exists().Should().BeTrue();
+
+            var calculateMd5 = NPath.FileSystem.CalculateMD5(gitLfsPath);
+            calculateMd5.ToLower().Should().Be(GitInstaller.MacGitLfsExecutableMD5.ToLower());
         }
     }
 }

src/tests/IntegrationTests/GitClientTests.cs

@@ -39,7 +39,7 @@ public async Task ShouldGetGitLfsVersion()
             var versionResult = version.Result;
             if (Environment.IsWindows)
             {
-                versionResult.Should().Be(new Version(2, 2, 0));
+                versionResult.Should().Be(new Version(2, 3, 0));
             }
             else
             {