Merge pull request #317 from github-for-unity/fixes/git-config-returns-null

Only change the result for process tasks that create a window

Author: shana

src/GitHub.Api/NewTaskSystem/ProcessTask.cs

@@ -288,8 +288,8 @@ protected override T RunWithReturn(bool success)
                     if (outputProcessor != null)
                         result = outputProcessor.Result;
 
-                    if (result == null && typeof(T) == typeof(string))
-                        result = (T)(object)(Process.StartInfo.CreateNoWindow ? "Process finished" : "Process running");
+                    if (result == null && !Process.StartInfo.CreateNoWindow && typeof(T) == typeof(string))
+                        result = (T)(object)"Process running";
 
                     RaiseOnEnd(result);
 

src/tests/IntegrationTests/Process/ProcessManagerIntegrationTests.cs

@@ -179,7 +179,6 @@ public async Task CredentialHelperGetTest()
             s = await ProcessManager
                 .GetGitCreds(TestRepoMasterCleanSynchronized, Environment, GitEnvironment)
                 .StartAsAsync();
-            s.Should().NotBeNull();
         }
     }
 }