Make the IsBusy view property track the state of the repository where relevant

Author: shana

src/GitHub.Api/Git/IRepository.cs

@@ -60,6 +60,7 @@ public interface IRepository : IEquatable<IRepository>, IDisposable
         List<GitLock> CurrentLocks { get; }
         string CurrentBranchName { get; }
         List<GitLogEntry> CurrentLog { get; }
+        bool IsBusy { get; }
 
         event Action<CacheUpdateEvent> LogChanged;
         event Action<CacheUpdateEvent> TrackingStatusChanged;

src/GitHub.Api/Git/Repository.cs

@@ -368,6 +368,7 @@ public string Name
         public NPath LocalPath { get; private set; }
         public string Owner => CloneUrl?.Owner ?? null;
         public bool IsGitHub => HostAddress.IsGitHubDotCom(CloneUrl);
+        public bool IsBusy => repositoryManager?.IsBusy ?? false;
 
         internal string DebuggerDisplay => String.Format(CultureInfo.InvariantCulture,
             "{0} Owner: {1} Name: {2} CloneUrl: {3} LocalPath: {4} Branch: {5} Remote: {6}", GetHashCode(), Owner, Name,

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/BranchesView.cs

@@ -501,11 +501,6 @@ private int CompareBranches(GitBranch a, GitBranch b)
             return a.Name.CompareTo(b.Name);
         }
 
-        public override bool IsBusy
-        {
-            get { return false; }
-        }
-
         private enum NodeType
         {
             Folder,

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ChangesView.cs

@@ -347,9 +347,6 @@ private void SelectNone()
 
         private void Commit()
         {
-            // Do not allow new commits before we have received one successful update
-            SetBusy(true);
-
             var files = treeChanges.GetCheckedFiles().ToList();
             ITask addTask;
 
@@ -367,19 +364,7 @@ private void Commit()
                     {
                         commitMessage = "";
                         commitBody = "";
-                        SetBusy(false);
                     }).Start();
         }
-
-        private void SetBusy(bool value)
-        {
-            treeChanges.IsBusy = value;
-            isBusy = value;
-        }
-
-        public override bool IsBusy
-        {
-            get { return isBusy; }
-        }
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/HistoryView.cs

@@ -744,10 +744,5 @@ private void BuildTree()
             treeChanges.Load(selectedEntry.changes.Select(entry => new GitStatusEntryTreeData(entry)));
             Redraw();
         }
-
-        public override bool IsBusy
-        {
-            get { return false; }
-        }
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs

@@ -15,7 +15,6 @@ class InitProjectView : Subview
 
         [SerializeField] private CacheUpdateEvent lastCheckUserChangedEvent;
 
-        [NonSerialized] private bool isBusy;
         [NonSerialized] private bool userHasChanges;
         [NonSerialized] private bool gitExecutableIsSet;
 
@@ -66,10 +65,7 @@ public override void OnGUI()
                     {
                         if (GUILayout.Button(Localization.InitializeRepositoryButtonText, "Button"))
                         {
-                            isBusy = true;
-                            Manager.InitializeRepository()
-                                   .FinallyInUI((s, e) => isBusy = false)
-                                   .Start();
+                            Manager.InitializeRepository().Start();
                         }
                     }
                     EditorGUI.EndDisabledGroup();
@@ -125,10 +121,5 @@ private void MaybeUpdateData()
                 hasCompletedInitialCheck = true;
             }
         }
-
-        public override bool IsBusy
-        {
-            get { return isBusy;  }
-        }
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/Subview.cs

@@ -59,7 +59,11 @@ public virtual void Finish(bool result)
         public IUser User { get { return Parent.User; } }
         public bool HasUser { get { return Parent.HasUser; } }
         public bool HasFocus { get { return Parent != null && Parent.HasFocus; } }
-        public abstract bool IsBusy { get; }
+        public virtual bool IsBusy
+        {
+            get { return Manager.IsBusy || Repository != null ? Repository.IsBusy : false; }
+        }
+
         protected ITaskManager TaskManager { get { return Manager.TaskManager; } }
         protected IGitClient GitClient { get { return Manager.GitClient; } }
         protected IEnvironment Environment { get { return Manager.Environment; } }