Using CacheType to know cached data has never been populated

Author: StanleyGoldman

src/GitHub.Api/Git/Repository.cs

@@ -407,7 +407,7 @@ public User(ICacheContainer cacheContainer)
         public void CheckUserChangedEvent(CacheUpdateEvent cacheUpdateEvent)
         {
             var managedCache = cacheContainer.GitUserCache;
-            var raiseEvent = managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
+            var raiseEvent = !cacheUpdateEvent.IsInitialized || managedCache.LastUpdatedAt != cacheUpdateEvent.UpdatedTime;
 
             Logger.Trace("Check GitUserCache CacheUpdateEvent Current:{0} Check:{1} Result:{2}", managedCache.LastUpdatedAt,
                 cacheUpdateEvent.UpdatedTime, raiseEvent);
@@ -502,6 +502,8 @@ public struct CacheUpdateEvent
 
         public CacheUpdateEvent(CacheType type, DateTimeOffset when)
         {
+            if (type == CacheType.None) throw new ArgumentOutOfRangeException(nameof(type));
+
             cacheType = type;
             updatedTimeValue = when;
             updatedTimeString = when.ToString(Constants.Iso8601Format);
@@ -562,19 +564,17 @@ public DateTimeOffset UpdatedTime
                     }
                     else
                     {
-                        UpdatedTime = DateTimeOffset.MinValue;
+                        updatedTimeValue = DateTimeOffset.MinValue;
+                        updatedTimeString = updatedTimeValue.Value.ToString(Constants.Iso8601Format);
                     }
                 }
 
                 return updatedTimeValue.Value;
             }
-            set
-            {
-                updatedTimeValue = value;
-                updatedTimeString = value.ToString(Constants.Iso8601Format);
-            }
         }
 
+        public bool IsInitialized => cacheType != CacheType.None;
+
         public string UpdatedTimeString => updatedTimeString;
     }
 }

src/UnityExtension/Assets/Editor/GitHub.Unity/UI/UserSettingsView.cs

@@ -90,14 +90,10 @@ private void AttachHandlers()
         private void UserOnChanged(CacheUpdateEvent cacheUpdateEvent)
         {
             //Logger.Trace("UserOnChanged");
-
-            if (!lastCheckUserChangedEvent.Equals(cacheUpdateEvent))
-            {
-                lastCheckUserChangedEvent = cacheUpdateEvent;
-                userHasChanges = true;
-                isBusy = false;
-                Redraw();
-            }
+            lastCheckUserChangedEvent = cacheUpdateEvent;
+            userHasChanges = true;
+            isBusy = false;
+            Redraw();
         }
 
         private void DetachHandlers()