nix build system part 2 #1157
nix build system part 2 #1157
Check failed
There are 21 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | d725a62 | style(nix): sort outputs in dpdk build | Valid sign-off found |
| 🟢 | 071f0db | refactor(nix): move profiles.nix to nix folder | Valid sign-off found |
| 🟢 | 9811294 | build(nix): introduce x86_64 march flags | Valid sign-off found |
| 🟢 | 7fc1a82 | build(nix): introduce aarch64 march flags | Valid sign-off found |
| 🟢 | 6c4d52a | build(nix): introduce build profiles | Valid sign-off found |
| 🟢 | 425447b | build(nix): introduce cross compile / profile infr... | Valid sign-off found |
| 🟢 | 87beade | build(nix): compile dpdk_wrapper.a with nix | Valid sign-off found |
| 🟢 | 73193d8 | build(nix): make overlay user selectable | Valid sign-off found |
| 🟢 | 4796a4e | build(nix): add address sanitize profile | Valid sign-off found |
| 🟢 | 927ccfc | build(nix): add leak sanitize profile | Valid sign-off found |
| 🟢 | f96d5e7 | build(nix): add cfi sanitize profile | Valid sign-off found |
| 🟢 | 0f29693 | build(nix): add safe-stack sanitize profile | Valid sign-off found |
| 🟢 | 7d708cb | build(nix): add instrumentation profiles | Valid sign-off found |
| 🟢 | d316200 | build(nix): pipe sanitizer and instrumentation int... | Valid sign-off found |
| 🔴 | b384843 | build(nix): add thread sanitize profile | Sign-off not found |
| 🔴 | f78b613 | build(nix): forward cflags back to linker in optim... | Sign-off not found |
| 🔴 | 08214b2 | fix(nix): missing acc // for one offs | Sign-off not found |
| 🔴 | c0c2dfc | build(nix): make most sanitizers work | Sign-off not found |
| 🔴 | 2fdf972 | build(nix): add copyright headers | Sign-off not found |
| 🔴 | 25b8d4d | wip | Sign-off not found |
| 🔴 | eaddb02 | wip | Sign-off not found |
| 🔴 | f01ebe1 | wip | Sign-off not found |
| 🔴 | a7b3775 | wip | Sign-off not found |
| 🔴 | 09fb701 | wip | Sign-off not found |
| 🔴 | ab5bab5 | wip | Sign-off not found |
| 🔴 | df4fc7a | wip | Sign-off not found |
| 🔴 | 5b1363b | pkgsBuildHost | Sign-off not found |
| 🔴 | 9824d79 | wip | Sign-off not found |
| 🔴 | f50e3eb | pkgsBuildHost | Sign-off not found |
| 🔴 | 1ff5324 | wip (moderate rework) | Sign-off not found |
| 🔴 | af2674f | wip | Sign-off not found |
| 🔴 | b77c8f3 | hack | Sign-off not found |
| 🔴 | 4a5df4f | fix rust build | Sign-off not found |
| 🔴 | 47bb784 | dataplane now builds, but need to undo lots of hac... | Sign-off not found |
| 🔴 | 73ef319 | fix cross compile errooooor | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~35 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pr/daniel-noland/dpdk-sys-take-2-phase-2