Draft
Conversation
RussKie
reviewed
May 2, 2021
Comment on lines
+106
to
+107
| var diffData = await _client.ExecuteGetAsync<string>(request); | ||
| return diffData.Content; |
Member
There was a problem hiding this comment.
What happens if a request fails? E.g. 401, 404, 500, etc.
Author
There was a problem hiding this comment.
It looks like the GIthub plugin gets back text indicating the error message ("Not Found", etc.) and shows an error dialog indicating that it couldn't parse the diff.
I need to debug this further, as it seems even sending the PAT in the headers is not enough for one particular organization.
Add GetDiffData method so that clients can request PR diff data using RestClient with authentication.
nyankoframe
force-pushed
the
add-getdiffdata-method
branch
from
7f497dc to
b125ecd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GetDiffData method so that clients can request PR diff data using RestClient with authentication.